Fix/XSUP-69940/FortiManager parsing rule#44446
Draft
MosheEichler wants to merge 1 commit into
Draft
Conversation
Contributor
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
Contributor
|
|
Contributor
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status: 📋 Triage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
https://jira-dc.paloaltonetworks.com/browse/XSUP-69940
Description
Root Cause:
The parsing rule in FortiManager.xif used a generic regex regextract(_raw_log, "\d{2}:\d{2}:\d{2}") to extract the time component, which grabbed the first HH:MM:SS pattern found anywhere in the raw log — not necessarily the time= field. This caused the wrong timestamp (or the ingestion time fallback) to be stored in _time.
Fix applied in FortiManager.xif:
Changed the filter to specifically match date=YYYY-MM-DD time=HH:MM:SS tz=... key-value format
Changed tmp_date extraction to use date=(\d{4}-\d{2}-\d{2}) — anchored to the date= field
Changed tmp_time extraction to use time=(\d{2}:\d{2}:\d{2}) — anchored to the time= field
The tz= extraction was already correct and unchanged
Must have