Skip to content

Fix exceptions handling in task dynamic invocation #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheAngryByrd merged 1 commit into from
Apr 21, 2026
+3 −6
Merged

Fix exceptions handling in task dynamic invocation #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/FsToolkit.ErrorHandling/TaskOptionCE.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,7 @@ type TaskOptionBuilder() =
// If the `sm.Data.MethodBuilder` has already been set somewhere else (like While/WhileDynamic), we shouldn't continue
if sm.Data.IsTaskCompleted then
()

if step then
elif step then
sm.Data.SetResult()
else
match sm.ResumptionDynamicInfo.ResumptionData with
Expand Down
3 changes: 1 addition & 2 deletions src/FsToolkit.ErrorHandling/TaskValueOptionCE.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,7 @@ type TaskValueOptionBuilder() =
// If the `sm.Data.MethodBuilder` has already been set somewhere else (like While/WhileDynamic), we shouldn't continue
if sm.Data.IsTaskCompleted then
()

if step then
elif step then
sm.Data.SetResult()
else
match sm.ResumptionDynamicInfo.ResumptionData with
Expand Down
3 changes: 1 addition & 2 deletions src/FsToolkit.ErrorHandling/ValueTaskValueOptionCE.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,7 @@ type ValueTaskValueOptionBuilder() =
// If the `sm.Data.MethodBuilder` has already been set somewhere else (like While/WhileDynamic), we shouldn't continue
if sm.Data.IsTaskCompleted then
()

if step then
elif step then
sm.Data.SetResult()
else
match sm.ResumptionDynamicInfo.ResumptionData with
Expand Down
Loading