Support standalone Docker builds by internalizing repository cloning#83
Open
ale94mleon wants to merge 2 commits into
Open
Support standalone Docker builds by internalizing repository cloning#83ale94mleon wants to merge 2 commits into
ale94mleon wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Dockerfile relies on
COPYcommands that require the user to have a local clone of the repository to providesupervisord.confandstart.sh. This adds friction for users who want to build the image directly from a URL or a single file.This PR modifies the Dockerfile to
Remove the dependency on local files for the build process.
Perform a shallow clone of the repository into a temporary directory during the build.
Copy the required configuration files internally and clean up the temporary files to keep the image slim.
Benefits
Enables building via: docker build https://github.com/denizsafak/AutoSubSync.git
Simplifies the setup for users who don't intend to modify the source code.
Changes:
Replaced
COPY docker/...commands with a logic block that usesgit cloneandcp.Ensured proper cleanup of the temporary source folder to minimize layer size.