fix: Do not attempt to commit partial transactions on error

Committing partial transactions is a great way to induce data corruption by committing inconsistent data to the database. Transaction MUST always form a unit!

Fortunately, this probably never mattered in practice as PostgreSQL will put transactions with failed commands into an *aborted* state, where the only valid subsequent in-transaction command is rolling back partially or completely:

> […] Moreover, ROLLBACK TO is the only way to regain control of a transaction block that was put in aborted state by the system due to an error, short of rolling it back completely and starting again.

https://www.postgresql.org/docs/current/tutorial-transactions.html

So this “only” improves error messages and avoids an unnecessary round trip, not change application observable behaviour.

Author: ntninja

query/transaction.ts

@@ -513,7 +513,6 @@ export class Transaction {
       return (await this.#executeQuery(query)) as QueryArrayResult<T>;
     } catch (e) {
       if (e instanceof PostgresError || e instanceof Deno.errors.BrokenPipe) {
-        await this.commit();
         throw new TransactionError(this.name, e);
       }
       throw e;
@@ -615,7 +614,6 @@ export class Transaction {
       return (await this.#executeQuery(query)) as QueryObjectResult<T>;
     } catch (e) {
       if (e instanceof PostgresError || e instanceof Deno.errors.BrokenPipe) {
-        await this.commit();
         throw new TransactionError(this.name, e);
       }
       throw e;
@@ -759,7 +757,6 @@ export class Transaction {
       await this.queryArray(`ROLLBACK ${chain_option ? "AND CHAIN" : ""}`);
     } catch (e) {
       if (e instanceof PostgresError || e instanceof Deno.errors.BrokenPipe) {
-        await this.commit();
         throw new TransactionError(this.name, e);
       }
       throw e;
@@ -858,7 +855,6 @@ export class Transaction {
         await savepoint.update();
       } catch (e) {
         if (e instanceof PostgresError || e instanceof Deno.errors.BrokenPipe) {
-          await this.commit();
           throw new TransactionError(this.name, e);
         }
         throw e;
@@ -878,7 +874,6 @@ export class Transaction {
         await savepoint.update();
       } catch (e) {
         if (e instanceof PostgresError || e instanceof Deno.errors.BrokenPipe) {
-          await this.commit();
           throw new TransactionError(this.name, e);
         }
         throw e;