fix: Throw TransactionError if database was disconnected when issuing transaction command

Automatically reconnecting for an in-transaction queries is not supported, as we’d have to replay all previous queries and still risk inconsistency if any subsequently issued application queries depended on data previously read during the disconnected transaction.

We’d *also* have to keep a log of all previously returned data to verify that it hasn’t changed when reissuing the command – an unacceptable overhead, particularly since applications must be able to handle transaction conflicts anyway and this patch just makes disconnects look like any other “please retry transaction” condition.

Author: ntninja

query/transaction.ts

@@ -339,7 +339,7 @@ export class Transaction {
           this.#committed = true;
         }
       } catch (e) {
-        if (e instanceof PostgresError) {
+        if (e instanceof PostgresError || e instanceof Deno.errors.BrokenPipe) {
           throw new TransactionError(this.name, e);
         }
         throw e;
@@ -512,7 +512,7 @@ export class Transaction {
     try {
       return (await this.#executeQuery(query)) as QueryArrayResult<T>;
     } catch (e) {
-      if (e instanceof PostgresError) {
+      if (e instanceof PostgresError || e instanceof Deno.errors.BrokenPipe) {
         await this.commit();
         throw new TransactionError(this.name, e);
       }
@@ -614,7 +614,7 @@ export class Transaction {
     try {
       return (await this.#executeQuery(query)) as QueryObjectResult<T>;
     } catch (e) {
-      if (e instanceof PostgresError) {
+      if (e instanceof PostgresError || e instanceof Deno.errors.BrokenPipe) {
         await this.commit();
         throw new TransactionError(this.name, e);
       }
@@ -758,7 +758,7 @@ export class Transaction {
     try {
       await this.queryArray(`ROLLBACK ${chain_option ? "AND CHAIN" : ""}`);
     } catch (e) {
-      if (e instanceof PostgresError) {
+      if (e instanceof PostgresError || e instanceof Deno.errors.BrokenPipe) {
         await this.commit();
         throw new TransactionError(this.name, e);
       }
@@ -857,7 +857,7 @@ export class Transaction {
       try {
         await savepoint.update();
       } catch (e) {
-        if (e instanceof PostgresError) {
+        if (e instanceof PostgresError || e instanceof Deno.errors.BrokenPipe) {
           await this.commit();
           throw new TransactionError(this.name, e);
         }
@@ -877,7 +877,7 @@ export class Transaction {
       try {
         await savepoint.update();
       } catch (e) {
-        if (e instanceof PostgresError) {
+        if (e instanceof PostgresError || e instanceof Deno.errors.BrokenPipe) {
           await this.commit();
           throw new TransactionError(this.name, e);
         }