fix all warnings (#155)

* fix all warnings

* lint bench

* Remove sqlite ignore flag from lint step in CI workflow

* Remove sqlite from deno fmt ignore list in CI workflow

* ignore sqlite3 dir from deno lsp

* ignore sqlite3 dir from deno lsp

* Trigger CI

Author: sigmaSd

.github/workflows/ci.yml

@@ -19,10 +19,10 @@ jobs:
           deno-version: "v2.x"
 
       - name: Check Formatting
-        run: deno fmt --check --ignore=sqlite
+        run: deno fmt --check
 
       - name: Lint
-        run: deno lint --ignore=sqlite,bench
+        run: deno lint
 
       - name: Check
         run: deno check src/ test/ scripts/ mod.ts

bench/bench_bun.js

@@ -1,3 +1,4 @@
+import process from "node:process";
 import { Database } from "bun:sqlite";
 
 // Unsafe concurrency is default.

bench/bench_bun_ffi.js

@@ -1,3 +1,4 @@
+import process from "node:process";
 import { dlopen, ptr } from "bun:ffi";
 
 import {

bench/bench_deno_wasm.js

@@ -1,4 +1,4 @@
-import { DB } from "https://deno.land/x/sqlite/mod.ts";
+import { DB } from "https://deno.land/x/sqlite@v3.9.1/mod.ts";
 import { nextTick } from "https://deno.land/std@0.126.0/node/_next_tick.ts";
 
 const db = new DB(":memory:");

bench/bench_node.js

@@ -1,3 +1,4 @@
+import process from "node:process";
 const db = require("better-sqlite3")(":memory:");
 
 db.exec("PRAGMA auto_vacuum = none");

bench/northwind/deno_old.js

@@ -1,5 +1,5 @@
 import { Database } from "https://deno.land/x/sqlite3@0.4.3/mod.ts";
-import { bench, run } from "../node_modules/mitata/src/cli.mjs";
+import { bench, run } from "../../node_modules/mitata/src/cli.mjs";
 
 const db = new Database("./bench/northwind.sqlite");
 

bench/northwind/node.mjs

@@ -1,5 +1,5 @@
 import { bench, run } from "mitata";
-import { createRequire } from "module";
+import { createRequire } from "node:module";
 
 const require = createRequire(import.meta.url);
 const db = require("better-sqlite3")("./bench/northwind.sqlite");

deno.json

@@ -27,12 +27,6 @@
     "bench-bun:northwind": "bun run bench/northwind/bun.js"
   },
 
-  "fmt": {
-    "exclude": [
-      "sqlite"
-    ]
-  },
-
   "lint": {
     "exclude": ["bench"],
     "rules": {
@@ -46,5 +40,10 @@
         "explicit-module-boundary-types"
       ]
     }
+  },
+  "compilerOptions": {
+    "types": [
+      "./node_modules/bun-types/index.d.ts"
+    ]
   }
 }

package.json

@@ -23,5 +23,8 @@
   "dependencies": {
     "better-sqlite3": "^7.6.2",
     "mitata": "^0.1.6"
+  },
+  "devDependencies": {
+    "bun-types": "^1.2.14"
   }
 }

src/statement.ts

@@ -468,7 +468,13 @@ export class Statement<TStatement extends object = Record<string, any>> {
     )(getColumn);
     let status = sqlite3_step(handle);
     while (status === SQLITE3_ROW) {
-      result.push(getRowArray(handle, this.int64 ?? this.db.int64, this.parseJson ?? this.db.parseJson));
+      result.push(
+        getRowArray(
+          handle,
+          this.int64 ?? this.db.int64,
+          this.parseJson ?? this.db.parseJson,
+        ),
+      );
       status = sqlite3_step(handle);
     }
     if (status !== SQLITE3_DONE) {
@@ -501,7 +507,13 @@ export class Statement<TStatement extends object = Record<string, any>> {
     )(getColumn);
     let status = sqlite3_step(handle);
     while (status === SQLITE3_ROW) {
-      result.push(getRowArray(handle, this.int64 ?? this.db.int64, this.parseJson ?? this.db.parseJson));
+      result.push(
+        getRowArray(
+          handle,
+          this.int64 ?? this.db.int64,
+          this.parseJson ?? this.db.parseJson,
+        ),
+      );
       status = sqlite3_step(handle);
     }
     if (!this.#hasNoArgs && !this.#bound && params.length) {
@@ -514,9 +526,15 @@ export class Statement<TStatement extends object = Record<string, any>> {
     return result as T[];
   }
 
-  #rowObjectFn: ((h: Deno.PointerValue, int64: boolean, parseJson: boolean) => any) | undefined;
+  #rowObjectFn:
+    | ((h: Deno.PointerValue, int64: boolean, parseJson: boolean) => any)
+    | undefined;
 
-  getRowObject(): (h: Deno.PointerValue, int64: boolean, parseJson: boolean) => any {
+  getRowObject(): (
+    h: Deno.PointerValue,
+    int64: boolean,
+    parseJson: boolean,
+  ) => any {
     if (!this.#rowObjectFn || !this.#unsafeConcurrency) {
       const columnNames = this.columnNames();
       const getRowObject = new Function(
@@ -733,7 +751,7 @@ export class Statement<TStatement extends object = Record<string, any>> {
 
   /** Iterate over resultant rows from query. */
   *iter(...params: RestBindParameters): IterableIterator<any> {
-    this.#begin();  
+    this.#begin();
     this.#bindAll(params);
     const getRowObject = this.getRowObject();
     const int64 = this.int64 ?? this.db.int64;