fix: better byte size parsing

Author: crowlKats

sandbox/mod.ts

@@ -7,7 +7,7 @@ import { join } from "@std/path";
 import { Spinner } from "@std/cli/unstable-spinner";
 
 import { getAppFromConfig, readConfig, writeConfig } from "../config.ts";
-import { error, parseSize, renderTemporalTimestamp, withApp } from "../util.ts";
+import { error, parseSizeToMib, renderTemporalTimestamp, withApp } from "../util.ts";
 import { createTrpcClient, getAuth } from "../auth.ts";
 import type { GlobalOptions } from "../main.ts";
 import token_storage from "../token_storage.ts";
@@ -54,7 +54,7 @@ export const sandboxCreateCommand = new Command<SandboxContext>()
       token,
       org,
       lifetime: options.lifetime as `${number}s` | `${number}m` | "session",
-      memoryMb: parseSize(options.memory),
+      memoryMb: parseSizeToMib(options.memory),
     });
     if (options.lifetime === "session" || options.ssh) {
       console.log(`Created sandbox with id '${sandbox.id}'`);

sandbox/volumes.ts

@@ -2,7 +2,7 @@ import { Command } from "@cliffy/command";
 import { ensureOrg, type SandboxContext } from "./mod.ts";
 import { getAuth } from "../auth.ts";
 import { Client } from "@deno/sandbox";
-import { formatSize, parseSize, tablePrinter } from "../util.ts";
+import { formatSize, parseSizeToMib, tablePrinter } from "../util.ts";
 
 export const volumesCreateCommand = new Command<SandboxContext>()
   .description("Create a volume")
@@ -23,7 +23,7 @@ export const volumesCreateCommand = new Command<SandboxContext>()
 
     const volume = await client.volumes.create({
       slug: name,
-      capacity: parseSize(options.capacity)!,
+      capacity: parseSizeToMib(options.capacity)!,
       region: options.region,
     });
 

util.ts

@@ -194,7 +194,7 @@ export function formatSize(bytes: number): string {
   return `${bytes} Bytes`;
 }
 
-export function parseSize(size: string | undefined): number | undefined {
+export function parseSizeToMib(size: string | undefined): number | undefined {
   if (size === undefined) return undefined;
 
   const match = size.match(/^(\d+)(GB|MB|KB|GiB|MiB|KiB)$/i);
@@ -205,21 +205,32 @@ export function parseSize(size: string | undefined): number | undefined {
     );
   }
   const [, numStr, unit] = match;
-  const num = parseInt(numStr, 10);
+  const num = parseFloat(numStr);
+
+  let bytes = 0;
+
   switch (unit.toLowerCase()) {
     case "gb":
-      return num * GIGABYTE;
+      bytes = num * GIGABYTE;
+      break;
     case "mb":
-      return num * MEGABYTE;
+      bytes = num * MEGABYTE;
+      break;
     case "kb":
-      return num * KILOBYTE;
+      bytes = num * KILOBYTE;
+      break;
     case "gib":
-      return num * GIBIBYTE;
+      bytes = num * GIBIBYTE;
+      break;
     case "mib":
-      return num * MEBIBYTE;
+      bytes = num * MEBIBYTE;
+      break;
     case "kib":
-      return num * KIBIBYTE;
+      bytes = num * KIBIBYTE;
+      break;
   }
+
+  return Math.floor(bytes / MEBIBYTE);
 }
 
 export function tablePrinter<T>(