feat: improve sandbox cli & add volumes management#38
Merged
Conversation
magurotuna
reviewed
Jan 5, 2026
Member
There was a problem hiding this comment.
Line 93 is this:
if (options.lifetime === "session" && options.ssh) {So despite the description text here, you need to pass --ssh in order to ssh into the created sandbox even when the lifetime is session, right?
Member
Author
There was a problem hiding this comment.
the description, but also the implmenetation, are wrong.
Now, --ssh is required to start a ssh, even with session lifetime (which, when --ssh is not passed, will keep the process open until exited).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds
deno sandbox deploysubcommandCloses #36
Closes https://github.com/denoland/deployng/issues/2287