Skip to content

fix: point Oak+SQLite CRUD example log to a real endpoint#3116

Merged
bartlomieju merged 3 commits into
mainfrom
orch/issue-60
May 14, 2026
Merged

fix: point Oak+SQLite CRUD example log to a real endpoint#3116
bartlomieju merged 3 commits into
mainfrom
orch/issue-60

Conversation

@fibibot
Copy link
Copy Markdown
Contributor

@fibibot fibibot commented May 14, 2026

Summary

The Oak + SQLite CRUD example logs Server is running on http://localhost:8369 on startup, but it only registers routes under /people. A reader who follows the log and opens the printed URL in a browser sees a 404 (reported in #2980).

This updates the startup log to direct readers at an endpoint that actually exists:

console.log(`Server is running on http://localhost:${PORT} — try GET /people`);

Smallest fix from the three options floated in the upstream issue — keeps the example single-concept (CRUD) without adding a placeholder / route or noisy curl comments.

cc @bartlomieju

Fixes #2980
Closes bartlomieju/orchid-inbox#60

Test plan

  • deno run -A examples/scripts/http_server_oak_crud_middleware_with_sqlite3_db.ts — confirmed startup log now reads Server is running on http://localhost:8369 — try GET /people
  • curl http://localhost:8369/people returns HTTP 200 with [] (non-404)

The startup log advertised `http://localhost:8369`, but the example
only registers routes under `/people`, so readers who visited the
logged URL in a browser got a 404. Update the log to point at the
existing `GET /people` endpoint.

Fixes #2980
Copy link
Copy Markdown
Contributor

@lunadogbot lunadogbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix matches the diff: routes are only under /people and /people/:id, so the unadorned http://localhost:8369 log was steering readers at a 404. Appending — try GET /people resolves that without inflating the example.

Holding approval until CI is green (lint job still in progress).

@bartlomieju bartlomieju merged commit f588f0e into main May 14, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feedback: /examples/http_server_oak_crud_middleware_with_sqlite3_db/ - Needs Improvement

3 participants