fix: point Oak+SQLite CRUD example log to a real endpoint#3116
Merged
Conversation
The startup log advertised `http://localhost:8369`, but the example only registers routes under `/people`, so readers who visited the logged URL in a browser got a 404. Update the log to point at the existing `GET /people` endpoint. Fixes #2980
lunadogbot
reviewed
May 14, 2026
Contributor
lunadogbot
left a comment
There was a problem hiding this comment.
Fix matches the diff: routes are only under /people and /people/:id, so the unadorned http://localhost:8369 log was steering readers at a 404. Appending — try GET /people resolves that without inflating the example.
Holding approval until CI is green (lint job still in progress).
bartlomieju
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Oak + SQLite CRUD example logs
Server is running on http://localhost:8369on startup, but it only registers routes under/people. A reader who follows the log and opens the printed URL in a browser sees a 404 (reported in #2980).This updates the startup log to direct readers at an endpoint that actually exists:
Smallest fix from the three options floated in the upstream issue — keeps the example single-concept (CRUD) without adding a placeholder
/route or noisycurlcomments.cc @bartlomieju
Fixes #2980
Closes bartlomieju/orchid-inbox#60
Test plan
deno run -A examples/scripts/http_server_oak_crud_middleware_with_sqlite3_db.ts— confirmed startup log now readsServer is running on http://localhost:8369 — try GET /peoplecurl http://localhost:8369/peoplereturns HTTP 200 with[](non-404)