feat(http/unstable): add RFC 9421 message signatures#7039
feat(http/unstable): add RFC 9421 message signatures#7039bartlomieju merged 13 commits intodenoland:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7039 +/- ##
==========================================
+ Coverage 94.50% 94.55% +0.05%
==========================================
Files 630 631 +1
Lines 50777 51392 +615
Branches 9037 9235 +198
==========================================
+ Hits 47985 48595 +610
- Misses 2224 2225 +1
- Partials 568 572 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bartlomieju
left a comment
There was a problem hiding this comment.
Thanks for the thorough implementation! A few things to address:
badge.svg changes don't belong in this PR — The reformatting of the SVG is unrelated to message signatures. Please drop it from the branch (or submit separately).
|
T%hanks for the feedback!
|
bartlomieju
left a comment
There was a problem hiding this comment.
Previous round's feedback is fully addressed (ECDSA/HMAC/RSA-PSS throws, ;bs docs, @query-param RFC citation). This is a solid RFC 9421 implementation — well-structured, thorough tests, good use of the existing structured fields module.
A couple of things I'd like addressed before approving:
9eb6880 to
a367c57
Compare
|
Thanks,
|
Add HTTP Message Signatures (RFC 9421) for signing and verifying HTTP requests and responses. Builds on the structured fields module (RFC 8941) already in std.
Coverage is as good as I can get it. There are a few lines of unreachable code.