Only include asset:///lib.node.d.ts when no @types/node package exists#16
Merged
Conversation
dsherret
marked this pull request as ready for review
December 4, 2025 22:54
bartlomieju
approved these changes
Dec 5, 2025
bartlomieju
pushed a commit
to denoland/deno
that referenced
this pull request
Dec 9, 2025
This adds a new "node" lib that's included by default and can be excluded by providing a custom `"lib": [...]` typescript compiler option without the `"node"` value. If it detects a `@types/node` package in the files being type checked it will skip injecting the `lib.node.d.ts` file. * Uses `npm:@types/node@24.2.0` * See tools/update_types_node.ts for the build script. * denoland/deno_npm#127 (will integrate this one later) * denoland/typescript-go#16 * denoland/TypeScript#19 (last two commits) Closes #30963
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.