Re-enable displaying type errors in pyrefly#5046
Open
sivel wants to merge 4 commits into
Open
Conversation
Author
|
cc @oliverralbertini @connernilsen if either of you are interested |
connernilsen
left a comment
connernilsen
left a comment
There was a problem hiding this comment.
Thanks for doing this @sivel! Left two comments around documentation clarity, but otherwise looks great!
oliverralbertini
approved these changes
Sep 24, 2025
Contributor
oliverralbertini
left a comment
oliverralbertini
left a comment
There was a problem hiding this comment.
Thanks for adding this.
Author
|
@hsanson I've addressed the linting issue that CI uncovered. I think the tests can be kicked off again. |
hsanson
approved these changes
Nov 22, 2025
Member
|
I'll paste this in every open PR: We finally managed to migrate CI checks for Windows from AppVeyor to GitHub Actions, and we've updated the minimum supported Vim version to 8.2. (Thought Vim 8.0 might happen to work for some.) In order to get checks to run again for a PR you'll need to rebase or merge. |
sivel
force-pushed
the
pyrefly-display-type-errors
branch
from
b3fa0a4 to
ab40915
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
pyrefly0.31.1a new configurationpython.pyrefly.displayTypeErrorswas added, changing the previous default behavior.This PR adds the appropriate LSP configuration to restore the behavior for the ale pyrefly linter, including a new
python_pyrefly_configoption to allow further configuration of the LSP.