-
Notifications
You must be signed in to change notification settings - Fork 0
Add condition cache query profiling #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peterxcli
wants to merge
1
commit into
main
Choose a base branch
from
peter/query-profile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,6 +60,17 @@ struct CacheEntryStats { | |
| idx_t total_row_groups; | ||
| }; | ||
|
|
||
| struct ConditionCacheProfileInfo { | ||
| atomic<bool> initial_lookup_hit {false}; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. comment needed |
||
| atomic<bool> built_this_query {false}; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. comment needed, also we should name the variable as noun_verb_ed |
||
|
|
||
| string predicate_hash; | ||
| idx_t cached_row_groups = 0; | ||
| idx_t qualifying_vectors = 0; | ||
| idx_t total_vectors = 0; | ||
| idx_t total_rows = 0; | ||
| }; | ||
|
|
||
| // A single cache entry: the bitvectors for one (table, predicate) combination. | ||
| struct ConditionCacheEntry : public ObjectCacheEntry { | ||
| static string ObjectType() { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # name: test/sql/condition_cache_explain.test | ||
| # description: Test condition cache stats in EXPLAIN ANALYZE and JSON profiling | ||
| # group: [sql] | ||
|
|
||
| require query_condition_cache | ||
|
|
||
| statement ok | ||
| CREATE TABLE t AS SELECT i AS id FROM range(500000) t(i); | ||
|
|
||
| query II | ||
| EXPLAIN (ANALYZE, FORMAT JSON) SELECT count(*) FROM t WHERE id < 3000; | ||
| ---- | ||
| analyzed_plan <REGEX>:.*"Condition Cache": "MISS -> BUILT".*"Condition Cache Predicate Hash": "[0-9]+".*"Condition Cache Cached Row Groups": "5".*"Condition Cache Qualifying Vectors": "2/245".* | ||
|
|
||
| statement ok | ||
| PRAGMA enable_profiling='json'; | ||
|
|
||
| statement ok | ||
| PRAGMA profiling_output='__TEST_DIR__/condition_cache_profile.json'; | ||
|
|
||
| statement ok | ||
| SELECT count(*) FROM t WHERE id < 3000; | ||
|
|
||
| statement ok | ||
| PRAGMA disable_profiling; | ||
|
|
||
| query I | ||
| SELECT contains(profile_json, 'Condition Cache') | ||
| AND contains(profile_json, 'HIT') | ||
| AND contains(profile_json, 'Condition Cache Predicate Hash') | ||
| AND contains(profile_json, 'Condition Cache Cached Row Groups') | ||
| AND contains(profile_json, 'Condition Cache Qualifying Vectors') | ||
| AND contains(profile_json, '2/245') | ||
| FROM ( | ||
| SELECT string_agg(json, '\n') AS profile_json | ||
| FROM read_csv('__TEST_DIR__/condition_cache_profile.json', columns={'json': 'VARCHAR'}, sep='🦆') | ||
| ); | ||
| ---- | ||
| true |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment needed, does the struct indicate a cache entry, singular/composite predicate, or a user query, a user connection