Note to prefer $() over ``, and update single example to conform#100
Open
matthewcurry wants to merge 2 commits into
Open
Note to prefer $() over ``, and update single example to conform#100matthewcurry wants to merge 2 commits into
matthewcurry wants to merge 2 commits into
Conversation
Collaborator
|
Nice catch, @matthewcurry 😃 I support this 💯 . We might want to swap the order of |
Author
|
Hey, I added a commit to make the change you suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Most code style guides dictate that
$()be used instead of``for command substitution. I made a very small change to your document to encourage its use.Thanks,
Matthew