Skip Gradle cooldown metadata fetch when cooldown is not configured

Avoids unnecessary network requests to fetch release-date metadata on
every Gradle job when the user has no cooldown configured (the default).

Fixes #14152

Author: yeikel

gradle/lib/dependabot/gradle/package/package_details_fetcher.rb

@@ -15,6 +15,7 @@
 require "dependabot/gradle/metadata_finder"
 require "dependabot/gradle/package/release_date_extractor"
 require "dependabot/gradle/package/version_release_date_fallback_fetcher"
+require "dependabot/package/release_cooldown_options"
 
 module Dependabot
   module Gradle
@@ -31,14 +32,16 @@ class PackageDetailsFetcher
             dependency: Dependabot::Dependency,
             dependency_files: T::Array[Dependabot::DependencyFile],
             credentials: T::Array[Dependabot::Credential],
-            forbidden_urls: T.nilable(T::Array[String])
+            forbidden_urls: T.nilable(T::Array[String]),
+            cooldown_options: T.nilable(Dependabot::Package::ReleaseCooldownOptions)
           ).void
         end
-        def initialize(dependency:, dependency_files:, credentials:, forbidden_urls:)
+        def initialize(dependency:, dependency_files:, credentials:, forbidden_urls:, cooldown_options: nil)
           @dependency = dependency
           @dependency_files = dependency_files
           @credentials = credentials
           @forbidden_urls = forbidden_urls
+          @cooldown_options = T.let(cooldown_options, T.nilable(Dependabot::Package::ReleaseCooldownOptions))
           @repositories = T.let(nil, T.nilable(T::Array[T::Hash[String, T.untyped]]))
           @google_version_details = T.let(nil, T.nilable(T::Array[T::Hash[String, T.untyped]]))
           @dependency_repository_details = T.let(nil, T.nilable(T::Array[T::Hash[String, T.untyped]]))
@@ -77,7 +80,7 @@ def fetch_available_versions
             end.flatten.compact
 
           version_details = version_details.sort_by { |details| details.fetch(:version) }
-          release_date_info = release_details
+          release_date_info = @cooldown_options ? release_details : {}
           version_details.each do |info|
             package_releases << {
               version: Gradle::Version.new(info[:version].to_s),

gradle/lib/dependabot/gradle/update_checker/version_finder.rb

@@ -124,7 +124,8 @@ def versions
             dependency: dependency,
             dependency_files: dependency_files,
             credentials: credentials,
-            forbidden_urls: forbidden_urls
+            forbidden_urls: forbidden_urls,
+            cooldown_options: cooldown_options
           ).fetch_available_versions
         end
 
@@ -169,7 +170,8 @@ def package_details_fetcher
               dependency: dependency,
               dependency_files: dependency_files,
               credentials: credentials,
-              forbidden_urls: []
+              forbidden_urls: [],
+              cooldown_options: cooldown_options
             ),
             T.nilable(Dependabot::Gradle::Package::PackageDetailsFetcher)
           )

gradle/spec/dependabot/gradle/package/package_details_fetcher_spec.rb

@@ -7,13 +7,14 @@
 require "dependabot/gradle/update_checker/version_finder"
 
 RSpec.describe Dependabot::Gradle::Package::PackageDetailsFetcher do
+  let(:cooldown_options) { nil }
   let(:packagedetailsfetcher) do
     described_class.new(
       dependency: dependency,
       dependency_files: dependency_files,
       credentials: credentials,
-
-      forbidden_urls: []
+      forbidden_urls: [],
+      cooldown_options: cooldown_options
     )
   end
   let(:version_class) { Dependabot::Gradle::Version }
@@ -62,6 +63,27 @@
   describe "#versions" do
     subject(:versions) { packagedetailsfetcher.fetch_available_versions }
 
+    context "when cooldown_options is nil" do
+      it "does not fetch release metadata" do
+        expect(packagedetailsfetcher).not_to receive(:release_details)
+        packagedetailsfetcher.fetch_available_versions
+      end
+    end
+
+    context "when cooldown_options is configured" do
+      let(:cooldown_options) { Dependabot::Package::ReleaseCooldownOptions.new(default_days: 7) }
+
+      before do
+        stub_request(:get, "https://repo.maven.apache.org/maven2/com/google/guava/guava/")
+          .to_return(status: 200, body: "")
+      end
+
+      it "fetches release metadata" do
+        expect(packagedetailsfetcher).to receive(:release_details).and_call_original
+        packagedetailsfetcher.fetch_available_versions
+      end
+    end
+
     its(:count) { is_expected.to eq(70) }
 
     describe "the first version" do
@@ -310,9 +332,17 @@
           is_expected.to eq("https://plugins.gradle.org/m2")
         end
 
-        its([:released_at]) do
-          # lastUpdated from fixture: 20190404053033 (2019-04-04 05:30:33 UTC)
-          is_expected.to eq(Time.utc(2019, 4, 4, 5, 30, 33))
+        context "without cooldown configured" do
+          its([:released_at]) { is_expected.to be_nil }
+        end
+
+        context "with cooldown configured" do
+          let(:cooldown_options) { Dependabot::Package::ReleaseCooldownOptions.new(default_days: 7) }
+
+          its([:released_at]) do
+            # lastUpdated from fixture: 20190404053033 (2019-04-04 05:30:33 UTC)
+            is_expected.to eq(Time.utc(2019, 4, 4, 5, 30, 33))
+          end
         end
       end
     end
@@ -390,9 +420,17 @@
           is_expected.to eq("https://plugins.gradle.org/m2")
         end
 
-        its([:released_at]) do
-          # lastUpdated from fixture: 20201222143435 (2020-12-22 14:34:35 UTC)
-          is_expected.to eq(Time.utc(2020, 12, 22, 14, 34, 35))
+        context "without cooldown configured" do
+          its([:released_at]) { is_expected.to be_nil }
+        end
+
+        context "with cooldown configured" do
+          let(:cooldown_options) { Dependabot::Package::ReleaseCooldownOptions.new(default_days: 7) }
+
+          its([:released_at]) do
+            # lastUpdated from fixture: 20201222143435 (2020-12-22 14:34:35 UTC)
+            is_expected.to eq(Time.utc(2020, 12, 22, 14, 34, 35))
+          end
         end
       end
     end