Refactor file fetcher specs to use a helper method for stubbing missing gradle wrapper files

Author: kbukum1

gradle/spec/dependabot/gradle/file_fetcher_spec.rb

@@ -48,18 +48,19 @@ def stub_no_content_request(path)
       .to_return(status: 404)
   end
 
+  def stub_no_wrapper_files(prefix = "")
+    stub_no_content_request("#{prefix}gradle/wrapper?ref=sha")
+    stub_no_content_request("#{prefix}gradlew?ref=sha")
+    stub_no_content_request("#{prefix}gradlew.bat?ref=sha")
+  end
+
   context "with a basic buildfile" do
     before do
       stub_no_content_request("gradle?ref=sha")
       stub_content_request("?ref=sha", "contents_java.json")
       stub_content_request("build.gradle?ref=sha", "contents_java_basic_buildfile.json")
       stub_no_content_request("gradle.lockfile?ref=sha")
-      # Stub wrapper files as missing by default (overridden in wrapper-specific tests)
-      stub_no_content_request("gradle/wrapper?ref=sha")
-      stub_no_content_request("gradlew?ref=sha")
-      stub_no_content_request("gradlew.bat?ref=sha")
-      stub_no_content_request("gradle/wrapper/gradle-wrapper.jar?ref=sha")
-      stub_no_content_request("gradle/wrapper/gradle-wrapper.properties?ref=sha")
+      stub_no_wrapper_files
     end
 
     it "fetches the buildfile" do
@@ -153,10 +154,7 @@ def stub_no_content_request(path)
           stub_content_request("buildSrc?ref=sha", "contents_java.json")
           stub_content_request("buildSrc/build.gradle?ref=sha", "contents_java_basic_buildfile.json")
           stub_no_content_request("buildSrc/gradle.lockfile?ref=sha")
-          # Stub wrapper files for buildSrc as missing
-          stub_no_content_request("buildSrc/gradle/wrapper?ref=sha")
-          stub_no_content_request("buildSrc/gradlew?ref=sha")
-          stub_no_content_request("buildSrc/gradlew.bat?ref=sha")
+          stub_no_wrapper_files("buildSrc/")
         end
 
         context "when the buildSrc is implicitly included" do
@@ -189,10 +187,7 @@ def stub_no_content_request(path)
             stub_content_request("included?ref=sha", "contents_java.json")
             stub_content_request("included/build.gradle?ref=sha", "contents_java_basic_buildfile.json")
             stub_no_content_request("included/gradle.lockfile?ref=sha")
-            # Stub wrapper files for included as missing
-            stub_no_content_request("included/gradle/wrapper?ref=sha")
-            stub_no_content_request("included/gradlew?ref=sha")
-            stub_no_content_request("included/gradlew.bat?ref=sha")
+            stub_no_wrapper_files("included/")
           end
 
           it "doesn't fetch buildSrc buildfiles twice" do
@@ -222,10 +217,7 @@ def stub_no_content_request(path)
           stub_no_content_request("included/gradle.lockfile?ref=sha")
           stub_content_request("included/app/build.gradle?ref=sha", "contents_java_basic_buildfile.json")
           stub_no_content_request("included/app/gradle.lockfile?ref=sha")
-          # Stub wrapper files for included as missing
-          stub_no_content_request("included/gradle/wrapper?ref=sha")
-          stub_no_content_request("included/gradlew?ref=sha")
-          stub_no_content_request("included/gradlew.bat?ref=sha")
+          stub_no_wrapper_files("included/")
         end
 
         it "fetches all buildfiles" do
@@ -261,13 +253,8 @@ def stub_no_content_request(path)
           stub_content_request("included2/settings.gradle?ref=sha", "contents_java_simple_settings.json")
           stub_content_request("included2/app/build.gradle?ref=sha", "contents_java_basic_buildfile.json")
           stub_no_content_request("included2/app/gradle.lockfile?ref=sha")
-          # Stub wrapper files for included builds as missing
-          stub_no_content_request("included/gradle/wrapper?ref=sha")
-          stub_no_content_request("included/gradlew?ref=sha")
-          stub_no_content_request("included/gradlew.bat?ref=sha")
-          stub_no_content_request("included2/gradle/wrapper?ref=sha")
-          stub_no_content_request("included2/gradlew?ref=sha")
-          stub_no_content_request("included2/gradlew.bat?ref=sha")
+          stub_no_wrapper_files("included/")
+          stub_no_wrapper_files("included2/")
         end
 
         it "fetches all buildfiles" do
@@ -316,19 +303,10 @@ def stub_no_content_request(path)
             "included/included/included/buildSrc/build.gradle?ref=sha",
             "contents_java_basic_buildfile.json"
           )
-          # Stub wrapper files for all included builds as missing
-          stub_no_content_request("included/gradle/wrapper?ref=sha")
-          stub_no_content_request("included/gradlew?ref=sha")
-          stub_no_content_request("included/gradlew.bat?ref=sha")
-          stub_no_content_request("included/included/gradle/wrapper?ref=sha")
-          stub_no_content_request("included/included/gradlew?ref=sha")
-          stub_no_content_request("included/included/gradlew.bat?ref=sha")
-          stub_no_content_request("included/included/included/gradle/wrapper?ref=sha")
-          stub_no_content_request("included/included/included/gradlew?ref=sha")
-          stub_no_content_request("included/included/included/gradlew.bat?ref=sha")
-          stub_no_content_request("included/included/included/buildSrc/gradle/wrapper?ref=sha")
-          stub_no_content_request("included/included/included/buildSrc/gradlew?ref=sha")
-          stub_no_content_request("included/included/included/buildSrc/gradlew.bat?ref=sha")
+          stub_no_wrapper_files("included/")
+          stub_no_wrapper_files("included/included/")
+          stub_no_wrapper_files("included/included/included/")
+          stub_no_wrapper_files("included/included/included/buildSrc/")
         end
 
         it "fetches all buildfiles transitively" do
@@ -361,10 +339,7 @@ def stub_no_content_request(path)
           stub_content_request("included/build.gradle?ref=sha", "contents_java_buildfile_with_script_plugins.json")
           stub_no_content_request("included/gradle.lockfile?ref=sha")
           stub_content_request("included/gradle/dependencies.gradle?ref=sha", "contents_java_simple_settings.json")
-          # Stub wrapper files for included as missing
-          stub_no_content_request("included/gradle/wrapper?ref=sha")
-          stub_no_content_request("included/gradlew?ref=sha")
-          stub_no_content_request("included/gradlew.bat?ref=sha")
+          stub_no_wrapper_files("included/")
         end
 
         it "fetches script plugin of main and included build" do
@@ -449,12 +424,7 @@ def stub_no_content_request(path)
       stub_content_request("?ref=sha", "contents_java.json")
       stub_content_request("build.gradle?ref=sha", "contents_java_buildfile_with_script_plugins.json")
       stub_content_request("gradle/dependencies.gradle?ref=sha", "contents_java_simple_settings.json")
-      # Stub wrapper files as missing by default
-      stub_no_content_request("gradle/wrapper?ref=sha")
-      stub_no_content_request("gradlew?ref=sha")
-      stub_no_content_request("gradlew.bat?ref=sha")
-      stub_no_content_request("gradle/wrapper/gradle-wrapper.jar?ref=sha")
-      stub_no_content_request("gradle/wrapper/gradle-wrapper.properties?ref=sha")
+      stub_no_wrapper_files
     end
 
     it "fetches the buildfile and the dependencies script" do
@@ -504,12 +474,7 @@ def stub_no_content_request(path)
           body: "[]",
           headers: { "content-type" => "application/json" }
         )
-      # Stub wrapper files as missing by default
-      stub_no_content_request("gradle/wrapper?ref=sha")
-      stub_no_content_request("gradlew?ref=sha")
-      stub_no_content_request("gradlew.bat?ref=sha")
-      stub_no_content_request("gradle/wrapper/gradle-wrapper.jar?ref=sha")
-      stub_no_content_request("gradle/wrapper/gradle-wrapper.properties?ref=sha")
+      stub_no_wrapper_files
     end
 
     it "raises dependency file not found" do