Skip to content

Commit 98ad7dc

Browse files
brettfoCopilot
brettfo
and
Copilot
committed
NuGet: Add FindRootDirectory experiment to resolve root entry points
When the `nuget-find-root-directory` experiment flag is enabled, the RunWorker scans the repo for .sln, .slnx, and .proj files and builds a child-to-parent mapping. It then walks upward from each job directory's project files to find the ultimate root entry points, replacing the job's directory list with the minimal ancestor set. This enables Dependabot to discover and update all projects reachable from a common root, even when the job is initially scoped to a single subdirectory. Includes: - EntryPointFinder utility with scanning, parent map building, and root walking - MSBuild evaluation for .proj files supporting globs, properties like $(MSBuildThisFileDirectory), and explicit references - Integration in RunWorker behind the experiment flag - 17 unit tests covering explicit refs, globs, MSBuild properties, transitive chains, cycles, and edge cases - 1 end-to-end test proving root directory expansion across a .proj chain with two projects in different directories Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 3949e06 commit 98ad7dc

7 files changed

Lines changed: 950 additions & 1 deletion

File tree

‎nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Discover/EntryPointFinderTests.cs‎

Lines changed: 430 additions & 0 deletions
Large diffs are not rendered by default.

‎nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Run/EndToEndTests.cs‎

Lines changed: 228 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1246,6 +1246,234 @@ await UpdateWorkerTestBase.MockNuGetPackagesInDirectory([
12461246
Assert.Equal("2.1.0", resolvedInLibrary);
12471247
}
12481248

1249+
[Fact]
1250+
public async Task FindRootDirectory_ExpandsDirectoryThroughProjChain()
1251+
{
1252+
// Job starts at /src/client, but a .proj chain leads up to the repo root.
1253+
// With FindRootDirectory enabled, the job should discover from "/" instead,
1254+
// which also picks up /test/client/client-test.csproj that would not be found
1255+
// if only /src/client were examined.
1256+
await RunAsync(
1257+
packages: [
1258+
MockNuGetPackage.CreateSimplePackage("Some.Package", "1.0.0", "net9.0"),
1259+
MockNuGetPackage.CreateSimplePackage("Some.Package", "2.0.0", "net9.0"),
1260+
],
1261+
job: new()
1262+
{
1263+
Source = new()
1264+
{
1265+
Provider = "github",
1266+
Repo = "test/repo",
1267+
Directory = "/src/client",
1268+
}
1269+
},
1270+
files: [
1271+
("Directory.Build.props", "<Project />"),
1272+
("Directory.Build.targets", "<Project />"),
1273+
("Directory.Packages.props", """
1274+
<Project>
1275+
<PropertyGroup>
1276+
<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>
1277+
</PropertyGroup>
1278+
</Project>
1279+
"""),
1280+
("dirs.proj", """
1281+
<Project>
1282+
<ItemGroup>
1283+
<ProjectFile Include="src\dirs.proj" />
1284+
<ProjectFile Include="test\dirs.proj" />
1285+
</ItemGroup>
1286+
</Project>
1287+
"""),
1288+
("src/dirs.proj", """
1289+
<Project>
1290+
<ItemGroup>
1291+
<ProjectFile Include="client\client.csproj" />
1292+
</ItemGroup>
1293+
</Project>
1294+
"""),
1295+
("test/dirs.proj", """
1296+
<Project>
1297+
<ItemGroup>
1298+
<ProjectFile Include="client\client-test.csproj" />
1299+
</ItemGroup>
1300+
</Project>
1301+
"""),
1302+
("src/client/client.csproj", """
1303+
<Project Sdk="Microsoft.NET.Sdk">
1304+
<PropertyGroup>
1305+
<TargetFramework>net9.0</TargetFramework>
1306+
</PropertyGroup>
1307+
<ItemGroup>
1308+
<PackageReference Include="Some.Package" Version="1.0.0" />
1309+
</ItemGroup>
1310+
</Project>
1311+
"""),
1312+
("test/client/client-test.csproj", """
1313+
<Project Sdk="Microsoft.NET.Sdk">
1314+
<PropertyGroup>
1315+
<TargetFramework>net9.0</TargetFramework>
1316+
</PropertyGroup>
1317+
<ItemGroup>
1318+
<PackageReference Include="Some.Package" Version="1.0.0" />
1319+
<ProjectReference Include="..\..\src\client\client.csproj" />
1320+
</ItemGroup>
1321+
</Project>
1322+
"""),
1323+
],
1324+
discoveryWorker: null,
1325+
analyzeWorker: null,
1326+
updaterWorker: null,
1327+
experimentsManager: new ExperimentsManager() { FindRootDirectory = true },
1328+
expectedApiMessages: [
1329+
new IncrementMetric()
1330+
{
1331+
Metric = "updater.started",
1332+
Tags = new()
1333+
{
1334+
["operation"] = "group_update_all_versions"
1335+
}
1336+
},
1337+
new UpdatedDependencyList()
1338+
{
1339+
Dependencies = [
1340+
new()
1341+
{
1342+
Name = "Some.Package",
1343+
Version = "1.0.0",
1344+
Requirements = [
1345+
new()
1346+
{
1347+
Requirement = "1.0.0",
1348+
File = "/src/client/client.csproj",
1349+
Groups = ["dependencies"],
1350+
}
1351+
]
1352+
},
1353+
new()
1354+
{
1355+
Name = "Some.Package",
1356+
Version = "1.0.0",
1357+
Requirements = [
1358+
new()
1359+
{
1360+
Requirement = "1.0.0",
1361+
File = "/test/client/client-test.csproj",
1362+
Groups = ["dependencies"],
1363+
}
1364+
]
1365+
},
1366+
],
1367+
DependencyFiles = [
1368+
"/Directory.Build.props",
1369+
"/Directory.Build.targets",
1370+
"/Directory.Packages.props",
1371+
"/src/client/client.csproj",
1372+
"/test/client/client-test.csproj",
1373+
],
1374+
},
1375+
new CreatePullRequest()
1376+
{
1377+
Dependencies = [
1378+
new()
1379+
{
1380+
Name = "Some.Package",
1381+
Version = "2.0.0",
1382+
Requirements = [
1383+
new()
1384+
{
1385+
Requirement = "2.0.0",
1386+
File = "/src/client/client.csproj",
1387+
Groups = ["dependencies"],
1388+
Source = new()
1389+
{
1390+
SourceUrl = null,
1391+
Type = "nuget_repo",
1392+
}
1393+
}
1394+
],
1395+
PreviousVersion = "1.0.0",
1396+
PreviousRequirements = [
1397+
new()
1398+
{
1399+
Requirement = "1.0.0",
1400+
File = "/src/client/client.csproj",
1401+
Groups = ["dependencies"],
1402+
}
1403+
],
1404+
},
1405+
new()
1406+
{
1407+
Name = "Some.Package",
1408+
Version = "2.0.0",
1409+
Requirements = [
1410+
new()
1411+
{
1412+
Requirement = "2.0.0",
1413+
File = "/test/client/client-test.csproj",
1414+
Groups = ["dependencies"],
1415+
Source = new()
1416+
{
1417+
SourceUrl = null,
1418+
Type = "nuget_repo",
1419+
}
1420+
}
1421+
],
1422+
PreviousVersion = "1.0.0",
1423+
PreviousRequirements = [
1424+
new()
1425+
{
1426+
Requirement = "1.0.0",
1427+
File = "/test/client/client-test.csproj",
1428+
Groups = ["dependencies"],
1429+
}
1430+
],
1431+
},
1432+
],
1433+
UpdatedDependencyFiles = [
1434+
new()
1435+
{
1436+
Directory = "/src/client",
1437+
Name = "client.csproj",
1438+
Content = """
1439+
<Project Sdk="Microsoft.NET.Sdk">
1440+
<PropertyGroup>
1441+
<TargetFramework>net9.0</TargetFramework>
1442+
</PropertyGroup>
1443+
<ItemGroup>
1444+
<PackageReference Include="Some.Package" Version="2.0.0" />
1445+
</ItemGroup>
1446+
</Project>
1447+
"""
1448+
},
1449+
new()
1450+
{
1451+
Directory = "/test/client",
1452+
Name = "client-test.csproj",
1453+
Content = """
1454+
<Project Sdk="Microsoft.NET.Sdk">
1455+
<PropertyGroup>
1456+
<TargetFramework>net9.0</TargetFramework>
1457+
</PropertyGroup>
1458+
<ItemGroup>
1459+
<PackageReference Include="Some.Package" Version="2.0.0" />
1460+
<ProjectReference Include="..\..\src\client\client.csproj" />
1461+
</ItemGroup>
1462+
</Project>
1463+
"""
1464+
},
1465+
],
1466+
BaseCommitSha = "TEST-COMMIT-SHA",
1467+
CommitMessage = TestPullRequestCommitMessage,
1468+
PrTitle = TestPullRequestTitle,
1469+
PrBody = TestPullRequestBody,
1470+
DependencyGroup = null,
1471+
},
1472+
new MarkAsProcessed("TEST-COMMIT-SHA")
1473+
]
1474+
);
1475+
}
1476+
12491477
public const string TestPullRequestCommitMessage = "test-pull-request-commit-message";
12501478
public const string TestPullRequestTitle = "test-pull-request-title";
12511479
public const string TestPullRequestBody = "test-pull-request-body";

0 commit comments

Comments
 (0)