Merge pull request #15088 from dependabot/dev/brettfo/nuget-missing-log

brettfo · web-flow · commit 9bfd0b8e33b0 · 2026-05-21T15:02:09.000-06:00
raise generic error without path information
diff --git a/nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/SdkProjectDiscovery.cs b/nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/SdkProjectDiscovery.cs
@@ -213,6 +213,11 @@ public static async Task<ImmutableArray<ProjectDiscoveryResult>> DiscoverAsync(s
                     logger.Warn($"  Error determining dependencies from `{startingProjectPath}`:\nSTDOUT:\n{stdOut}\nSTDERR:\n{stdErr}");
                 }
 
+                if (!File.Exists(binLogPath))
+                {
+                    throw new FileNotFoundException("Dependency discovery didn't produce a log file.");
+                }
+
                 var buildRoot = BinaryLog.ReadBuild(binLogPath);
                 buildRoot.VisitAllChildren<BaseNode>(node =>
                 {

Original file line number	Diff line number	Diff line change
`@@ -213,6 +213,11 @@ public static async Task<ImmutableArray<ProjectDiscoveryResult>> DiscoverAsync(s`
`213`	`213`	logger.Warn($" Error determining dependencies from `{startingProjectPath}`:\nSTDOUT:\n{stdOut}\nSTDERR:\n{stdErr}");
`214`	`214`	`}`
`215`	`215`
	`216`	`+ if (!File.Exists(binLogPath))`
	`217`	`+ {`
	`218`	`+ throw new FileNotFoundException("Dependency discovery didn't produce a log file.");`
	`219`	`+ }`
	`220`	`+`
`216`	`221`	`var buildRoot = BinaryLog.ReadBuild(binLogPath);`
`217`	`222`	`buildRoot.VisitAllChildren<BaseNode>(node =>`
`218`	`223`	`{`