Skip to content

Commit bfaf2eb

Browse files
kbukum1Copilot
andcommitted
Avoid duplicate matching_blocked_entries call in log method
Compute filtered entries once in log_blocked_versions_for instead of calling both blocked_versions_for and matching_blocked_entries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 40ccc7d commit bfaf2eb

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

updater/lib/dependabot/job.rb

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -498,17 +498,19 @@ def blocked_versions_for(dependency)
498498

499499
sig { params(dependency: Dependabot::Dependency).void }
500500
def log_blocked_versions_for(dependency)
501-
versions = blocked_versions_for(dependency)
502-
return if versions.empty?
503-
504-
Dependabot.logger.info("Blocked versions (by GitHub Security):")
505-
matching_blocked_entries(dependency).each do |bv|
501+
entries = matching_blocked_entries(dependency).filter_map do |bv|
506502
version = bv["version"].strip
507503
next if version.empty?
508504

509505
reason = bv["reason"].is_a?(String) ? bv["reason"].strip : nil
510-
msg = " #{version}"
511-
msg += " - reason: #{reason}" if reason && !reason.empty?
506+
{ version: version, reason: reason&.empty? ? nil : reason }
507+
end
508+
return if entries.empty?
509+
510+
Dependabot.logger.info("Blocked versions (by GitHub Security):")
511+
entries.each do |entry|
512+
msg = " #{entry[:version]}"
513+
msg += " - reason: #{entry[:reason]}" if entry[:reason]
512514
Dependabot.logger.info(msg)
513515
end
514516
end

0 commit comments

Comments
 (0)