Remove enable_record_ecosystem_meta feature flag (#14353)

* Remove enable_record_ecosystem_meta feature flag

The record_ecosystem_meta functionality is now always active (no longer
gated behind an experiment flag). Removed:
- Feature flag guard in api_client.rb
- Associated test stubs and "when feature flag is disabled" test context

Co-authored-by: pavera <660677+pavera@users.noreply.github.com>

* Fix lint and integration test failures

- Fix RuboCop Layout/EmptyLinesAroundBlockBody offense (extra empty line)
- Add stub_request for record_ecosystem_meta_url in spec
- Fix Go integration test: check message type before full struct unmarshal
  so record_ecosystem_meta messages (which have different data structure)
  are skipped gracefully instead of causing unmarshal errors

Co-authored-by: pavera <660677+pavera@users.noreply.github.com>

* Revert accidentally committed go_modules fixture files

Remove go.sum/go.mod fixture files that were accidentally picked up
by git add and are not related to the feature flag removal.

Co-authored-by: pavera <660677+pavera@users.noreply.github.com>

* Make record_ecosystem_meta best-effort without retries

Remove the retry loop from record_ecosystem_meta to avoid adding
up to ~30s of extra latency per job when the API call fails. Since
this is now unconditional and invoked from multiple ensure blocks,
it should be truly best-effort (like increment_metric) with no
sleep/retry behavior. Network errors and HTTP 4xx+ responses are
logged as errors without retrying.

Co-authored-by: pavera <660677+pavera@users.noreply.github.com>

* Simplify record_ecosystem_meta error handling

Remove redundant inner rescue for Excon/SSL errors since the outer
StandardError rescue already catches those. Single rescue block is
cleaner and matches the reviewer's suggested pattern.

Co-authored-by: pavera <660677+pavera@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pavera <660677+pavera@users.noreply.github.com>

Author: Copilot

silent/tests/silent_test.go

@@ -102,14 +102,20 @@ func prChecker(prType string) func(s *script.State, args ...string) (script.Wait
 		scanner := bufio.NewScanner(strings.NewReader(s.Stdout()))
 		var totalPRsCreated int
 		for scanner.Scan() {
+			var msg struct {
+				Type string `json:"type"`
+			}
+			if err := json.Unmarshal([]byte(scanner.Text()), &msg); err != nil {
+				return nil, fmt.Errorf("failed to decode line %s: %w", scanner.Text(), err)
+			}
+			if msg.Type != prType {
+				continue
+			}
 			var pr CreatePR
 			err := json.Unmarshal([]byte(scanner.Text()), &pr)
 			if err != nil {
 				return nil, fmt.Errorf("failed to decode line %s: %w", scanner.Text(), err)
 			}
-			if pr.Type != prType {
-				continue
-			}
 
 			totalPRsCreated++
 			if len(pr.Data.UpdatedDependencyFiles) == 0 {

updater/lib/dependabot/api_client.rb

@@ -308,46 +308,32 @@ def increment_metric(metric, tags:)
 
     sig { params(ecosystem: T.nilable(Ecosystem)).void }
     def record_ecosystem_meta(ecosystem)
-      return unless Dependabot::Experiments.enabled?(:enable_record_ecosystem_meta)
-
       return if ecosystem.nil?
 
-      begin
-        ::Dependabot::OpenTelemetry.tracer.in_span("record_ecosystem_meta", kind: :internal) do |_span|
-          api_url = "#{http_client.params[:path]}/update_jobs/#{job_id}/record_ecosystem_meta"
+      ::Dependabot::OpenTelemetry.tracer.in_span("record_ecosystem_meta", kind: :internal) do |_span|
+        api_url = "#{http_client.params[:path]}/update_jobs/#{job_id}/record_ecosystem_meta"
 
-          body = {
-            data: [
-              {
-                ecosystem: {
-                  name: ecosystem.name,
-                  package_manager: version_manager_json(ecosystem.package_manager),
-                  language: version_manager_json(ecosystem.language)
-                }
+        body = {
+          data: [
+            {
+              ecosystem: {
+                name: ecosystem.name,
+                package_manager: version_manager_json(ecosystem.package_manager),
+                language: version_manager_json(ecosystem.language)
               }
-            ]
-          }
-
-          retry_count = 0
+            }
+          ]
+        }
 
-          begin
-            response = http_client.post(path: api_url, body: body.to_json)
-            raise ApiError, response.body if response.status >= 400
-          rescue Excon::Error::Socket, Excon::Error::Timeout, OpenSSL::SSL::SSLError, ApiError => e
-            retry_count += 1
-            if retry_count <= MAX_REQUEST_RETRIES
-              sleep(rand(3.0..10.0))
-              retry
-            else
-              Dependabot.logger.error(
-                "Failed to record ecosystem meta after #{MAX_REQUEST_RETRIES} retries: #{e.message}"
-              )
-            end
-          end
+        response = http_client.post(path: api_url, body: body.to_json)
+        if response.status >= 400
+          Dependabot.logger.error(
+            "Failed to record ecosystem meta. Status: #{response.status}, body: #{response.body}"
+          )
         end
-      rescue StandardError => e
-        Dependabot.logger.error("Failed to record ecosystem meta: #{e.message}")
       end
+    rescue StandardError => e
+      Dependabot.logger.error("Failed to record ecosystem meta: #{e.message}")
     end
 
     # rubocop:disable Metrics/MethodLength

updater/spec/dependabot/api_client_spec.rb

@@ -83,7 +83,6 @@
 
     before do
       allow(Dependabot::PullRequestCreator::MessageBuilder).to receive_message_chain(:new, :message).and_return(message)
-      allow(Dependabot::Experiments).to receive(:enabled?).with(:enable_record_ecosystem_meta).and_return(true)
       stub_request(:post, create_pull_request_url)
         .to_return(status: 204, headers: headers)
     end
@@ -651,10 +650,6 @@
   end
 
   describe "record_ecosystem_meta" do
-    before do
-      allow(Dependabot::Experiments).to receive(:enabled?).with(:enable_record_ecosystem_meta).and_return(true)
-    end
-
     let(:ecosystem) do
       Dependabot::Ecosystem.new(
         name: "bundler",
@@ -683,6 +678,11 @@
     end
     let(:record_ecosystem_meta_url) { "http://example.com/update_jobs/1/record_ecosystem_meta" }
 
+    before do
+      stub_request(:post, record_ecosystem_meta_url)
+        .to_return(status: 204, headers: headers)
+    end
+
     it "hits the correct endpoint" do
       client.record_ecosystem_meta(ecosystem)
 
@@ -726,17 +726,6 @@
         expect(WebMock).not_to have_requested(:post, record_ecosystem_meta_url)
       end
     end
-
-    context "when feature flag is disabled" do
-      before do
-        allow(Dependabot::Experiments).to receive(:enabled?).with(:enable_record_ecosystem_meta).and_return(false)
-      end
-
-      it "does not send a request" do
-        client.record_ecosystem_meta(ecosystem)
-        expect(WebMock).not_to have_requested(:post, record_ecosystem_meta_url)
-      end
-    end
   end
 
   describe "record_cooldown_meta" do