Only run native wrapper updated if distribution dependency

Author: gmazzo

gradle/lib/dependabot/gradle/file_updater/wrapper_updater.rb

@@ -39,12 +39,15 @@ def initialize(dependency_files:, dependency:)
 
         sig { params(build_file: Dependabot::DependencyFile).returns(T::Array[Dependabot::DependencyFile]) }
         def update_files(build_file)
+          # We only run this updater if it's a distribution dependency
+          return [] unless Distributions.distribution_requirements?(dependency.requirements)
+
           local_files = dependency_files.select do |file|
             file.directory == build_file.directory && target_file?(file)
           end
 
           # If we don't have any files in the build files don't generate one
-          return dependency_files unless local_files.any?
+          return [] unless local_files.any?
 
           updated_files = dependency_files.dup
           SharedHelpers.in_a_temporary_directory do |temp_dir|

gradle/spec/dependabot/gradle/file_updater_spec.rb

@@ -37,7 +37,7 @@
     )
   end
   let(:dependencies) { [dependency] }
-  let(:dependency_files) { [buildfile] }
+  let(:dependency_files) { [buildfile, wrapper_file] }
   let(:updater) do
     described_class.new(
       dependency_files: dependency_files,
@@ -51,11 +51,34 @@
     )
   end
 
+  let(:wrapper_file) do
+    Dependabot::DependencyFile.new(
+      name: "gradle/wrapper/gradle-wrapper.properties",
+      content: fixture(
+        "wrapper_files",
+        "gradle-wrapper-8.14.2-bin.properties"
+      )
+    )
+  end
+
   it_behaves_like "a dependency file updater"
 
   describe "#updated_dependency_files" do
     subject(:updated_files) { updater.updated_dependency_files }
 
+    before do
+      allow(Dependabot::SharedHelpers).to receive(:run_shell_command) do |command, _|
+        raise "Unexpected shell command: #{command}"
+      end
+
+      Dependabot::Experiments.register(:gradle_wrapper_updater, true)
+      Dependabot::Experiments.register(:gradle_lockfile_updater, true)
+    end
+
+    after do
+      Dependabot::Experiments.reset!
+    end
+
     it "returns DependencyFile objects" do
       updated_files.each { |f| expect(f).to be_a(Dependabot::DependencyFile) }
     end
@@ -634,6 +657,10 @@
           end
 
           let(:buildfile) do
+            wrapper_file
+          end
+
+          let(:wrapper_file) do
             Dependabot::DependencyFile.new(
               name: "gradle/wrapper/gradle-wrapper.properties",
               content: fixture(
@@ -684,16 +711,25 @@
             )
           end
 
+          before do
+            allow(Dependabot::SharedHelpers).to receive(:run_shell_command)
+          end
+
           its(:content) do
+            expected_command = "gradle --no-daemon --stacktrace wrapper --no-validate-url --gradle-version 9.0.0"
+
             is_expected.to include(
               "distributionUrl=https\\://services.gradle.org/distributions/gradle-9.0.0-#{type}.zip"
             )
 
             if checksum
+              expected_command += " --gradle-distribution-sha256-sum #{updated_checksum}"
               is_expected.to include("distributionSha256Sum=#{updated_checksum}")
             else
               is_expected.not_to include("distributionSha256Sum=")
             end
+
+            expect(Dependabot::SharedHelpers).to have_received(:run_shell_command).with(expected_command, cwd: anything)
           end
         end