Updating Gradle Wrapper binaries support#12908
Closed
gmazzo wants to merge 9 commits into
Closed
Conversation
ffe2f83 to
e37c768
Compare
e37c768 to
321013e
Compare
92548a6 to
c2cf521
Compare
c2cf521 to
c0c402c
Compare
acf1838 to
992e9e0
Compare
7535c7f to
7cc8fa3
Compare
190690a to
96d9571
Compare
96d9571 to
6a3e02c
Compare
Contributor
Author
|
Closing, since it has been integrated into #12891 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Extends Gradle Wrapper support introduced by #12891 to also update
gradlewandgradle-wrapper.jarby running the nativewrappertask.Note
This PR is based on #12891, the real diff is here
Anything you want to highlight for special attention from reviewers?
Leverages the existing
LockfileUpdater, extracting most of its code into a newGradleUpdaterBaseclass, which has two abstract methods:target_file?to tell the given file is meant to be updated by itcommand_argsto collaborate with the finalgradlecommand runNow both
LockfileUpdaterand the newWrapperUpdaterinherit fromGradleUpdaterBase.Same as
LockfileUpdateris undergradle_lockfile_updaterfeature flag, a newgradle_wrapper_updateris used forWrapperUpdater.The update will not attempt to use any configuration for the
wrappertask in the main build script; many of the repos will be broken because they rely on other files or included builds that will take a long time to complete. We limit to copying the wrapper-related files and running a clean, empty build.How will you know you've accomplished your goal?
Running against a sample repo:
DEBUG_HELPERS=true bin/dry-run.rb gradle ReactiveX/RxJava --updater-options gradle_lockfile_updater,gradle_wrapper_updater --dep="gradle-wrapper"produces the desired diff:
Checklist