Fix OCI Helm chart metadata finder to strip oci:// prefix#13634
Fix OCI Helm chart metadata finder to strip oci:// prefix#13634Copilot wants to merge 9 commits into
Conversation
…pect Co-authored-by: robaiken <6567647+robaiken@users.noreply.github.com>
|
@copilot solve conflict docker/lib/dependabot/docker/metadata_finder.rb |
Co-authored-by: robaiken <6567647+robaiken@users.noreply.github.com>
Co-authored-by: robaiken <6567647+robaiken@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes missing release notes for OCI-based Helm chart updates by normalizing oci://-prefixed registry URLs before invoking regctl image inspect, allowing MetadataFinder to successfully read OCI labels like org.opencontainers.image.source.
Changes:
- Strip the
oci://prefix fromsource[:registry]before constructing theregctlimage reference. - Add an RSpec case covering OCI-prefixed Helm registry URLs and asserting the normalized
regctlcall and extracted source URL.
Show a summary per file
| File | Description |
|---|---|
| docker/lib/dependabot/docker/metadata_finder.rb | Normalizes OCI registry URLs by removing the oci:// scheme before calling regctl. |
| docker/spec/dependabot/docker/metadata_finder_spec.rb | Adds a regression spec ensuring OCI-prefixed Helm registries are inspected with a scheme-less reference. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 0
|
@copilot remove changes to nuget |
Co-authored-by: robaiken <6567647+robaiken@users.noreply.github.com>
Co-authored-by: robaiken <6567647+robaiken@users.noreply.github.com>
|
@copilot I still see |
Co-authored-by: robaiken <6567647+robaiken@users.noreply.github.com>
Co-authored-by: robaiken <6567647+robaiken@users.noreply.github.com>
Fixed in f5ec089. The previous revert commits cancelled each other out — the submodule pointers are now correctly restored to match |
What are you trying to accomplish?
OCI Helm charts from private registries update correctly but PRs lack release notes. The
MetadataFinderwas passingoci://prefixed URLs toregctl image inspect, which doesn't support that scheme:This strips the
oci://prefix before callingregctl, allowing it to extract theorg.opencontainers.image.sourcelabel for release notes.Fixes #13601
Anything you want to highlight for special attention from reviewers?
The fix is minimal—one line to normalize the registry URL:
This maintains backward compatibility for non-OCI registries (no prefix to strip).
How will you know you've accomplished your goal?
regctlcall with expected normalized URLChecklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
tuf-repo-cdn.sigstore.dev/opt/bin/cosign cosign verify --certificate-oidc-issuer REDACTED --certificate-identity-regexp REDACTED ghcr.io/regclient/regctl:v0.9.2(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This section details on the original issue you should resolve
<issue_title>OCI Helm chart from private repository updating, but without release notes</issue_title>
<issue_description>### Is there an existing issue for this?
Package ecosystem
helm
Package manager version
No response
Language version
No response
Manifest location and content before the Dependabot update
We are storing our Helm charts in a Google Artifact Registry repo. Authentication works, and it seems to also be able to get tags. But I think it cannot get the sources to be able to fetch release notes.
We have set
org.opencontainers.image.sourceon the OCI image, but running regctl locally fails because it doesn't support media typeapplication/vnd.cncf.helm.config.v1+json.When we push to the registry, we run
So we get an image called dependency-name with a tag -
1.7.4. In github the full tag isdependency-name-v1.7.4.infra/k8s/Chart.yaml
dependabot.yml content
Updated dependency
No response
What you expected to see, versus what you actually saw
Expecting the PR to contain release notes and changelogs from the github releases we have.
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
Anonymized logs: