Skip to content

Bumps npm/corepack to match the currently installed node LTS#14962

Open
pieterocp wants to merge 13 commits into
dependabot:mainfrom
pieterocp:bump-npm-version
Open

Bumps npm/corepack to match the currently installed node LTS#14962
pieterocp wants to merge 13 commits into
dependabot:mainfrom
pieterocp:bump-npm-version

Conversation

@pieterocp
Copy link
Copy Markdown

@pieterocp pieterocp commented May 10, 2026

This patches over the error mismatch in #14961 + temp work-around until #14139 is done

What are you trying to accomplish?

I want to be able to use npm 11.10+ with strict engine version(s) so I can use the min-release-age feature while having dependbot upgrade stuff. Given the repeated npm package hijacks, being able to enforce the engine as a hard blocker is a security essential to reduce the risk of pulling in malware on development/agent controlled machines.

See #14961, this is a temp fix by aligning the two versions. Really the npm --version needs some work to be whatever the Dockerfile is actually set to be.

Anything you want to highlight for special attention from reviewers?

I would like to highlight that this bump should be automatically by some tooling / someone should put a manual reminder a week after any node LTS release to do this.

How will you know you've accomplished your goal?

Once this is in, I press try again, and it works.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

This patches over the error mismatch in dependabot#14961 + temp work-around until dependabot#14139 is done

Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
@pieterocp pieterocp marked this pull request as ready for review May 10, 2026 09:56
@pieterocp pieterocp requested a review from a team as a code owner May 10, 2026 09:56
Copilot AI review requested due to automatic review settings May 10, 2026 09:56
@pieterocp
Copy link
Copy Markdown
Author

Smoke test looks to be failing already on other branches, guessing it's one where a lockfile needs a bit of updating?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the npm_and_yarn updater image’s pinned npm version to better align the corepack-managed npm with the Node LTS toolchain used in Dependabot, addressing the reported npm version mismatch in error output.

Changes:

  • Bump the Docker image NPM_VERSION build arg from 11.8.0 to 11.12.1.

Comment thread npm_and_yarn/Dockerfile Outdated
pieterocp and others added 2 commits May 14, 2026 08:59
(as per review feedback)

Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
@pieterocp pieterocp requested a review from yeikel May 14, 2026 10:10
Copy link
Copy Markdown
Contributor

@yeikel yeikel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have approval rights, but this change looks good. Thanks!

Comment thread npm_and_yarn/Dockerfile Outdated

# Check for updates at https://github.com/nodejs/corepack/releases
ARG COREPACK_VERSION=0.34.6
ARG COREPACK_VERSION=0.34.7
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump it to the version that was just released today?

Suggested change
ARG COREPACK_VERSION=0.34.7
ARG COREPACK_VERSION=0.35.0

Just to take advantage while we wait for a reviewer :)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it when back at my laptop, is the npm bumped too?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern is that this might be breaking the pnpm and some older smoke tests (and subsequently causing a break in functionality?).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread npm_and_yarn/Dockerfile
Comment on lines 4 to 6
# Check for updates at https://github.com/nodejs/corepack/releases
ARG COREPACK_VERSION=0.34.6
ARG COREPACK_VERSION=0.35.0

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

Comment thread npm_and_yarn/Dockerfile
Comment on lines 21 to +24
# Check for updates at https://github.com/npm/cli/releases
# This version should be aligned with NODEJS_VERSION version declared above. See https://nodejs.org/en/download/releases as well
# With every major release update, also update npm_and_yarn/lib/dependabot/npm_and_yarn/npm_package_manager.rb (Section : Update instructions)
ARG NPM_VERSION=11.8.0
ARG NPM_VERSION=11.12.1
@pieterocp pieterocp changed the title Bumps npm to 11.12.1 as per the currently installed LTS Bumps npm/corepack to match the currently installed node LTS May 18, 2026
@pieterocp pieterocp requested a review from yeikel May 18, 2026 10:10
@pieterocp
Copy link
Copy Markdown
Author

pieterocp commented May 20, 2026

I understand that it might be busy at Microsoft & GitHub since there have been a few big security breaches, but little things like this should help out, since being able to turn on strict engine requirements for every developer to use a version of npm that supports min-release-age without some dependabot exception will be useful.

Let me know/rebase/make a different PR for all I care, I just want to see this upgraded sooner to enable a good DX without having to compromise on security.

@yeikel
Copy link
Copy Markdown
Contributor

yeikel commented May 22, 2026

@kbukum1 Could you please review this?

@yeikel
Copy link
Copy Markdown
Contributor

yeikel commented May 22, 2026

I understand that it might be busy at Microsoft & GitHub since there have been a few big security breaches, but little things like this should help out, since being able to turn on strict engine requirements for every developer to use a version of npm that supports min-release-age without some dependabot exception will be useful.

Let me know/rebase/make a different PR for all I care, I just want to see this upgraded sooner to enable a good DX without having to compromise on security.

Thanks for the hard work. Hopefully someone with write permissions will get to it soon 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants