Bumps npm/corepack to match the currently installed node LTS#14962
Bumps npm/corepack to match the currently installed node LTS#14962pieterocp wants to merge 13 commits into
Conversation
This patches over the error mismatch in dependabot#14961 + temp work-around until dependabot#14139 is done Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
|
Smoke test looks to be failing already on other branches, guessing it's one where a lockfile needs a bit of updating? |
There was a problem hiding this comment.
Pull request overview
Updates the npm_and_yarn updater image’s pinned npm version to better align the corepack-managed npm with the Node LTS toolchain used in Dependabot, addressing the reported npm version mismatch in error output.
Changes:
- Bump the Docker image
NPM_VERSIONbuild arg from11.8.0to11.12.1.
(as per review feedback) Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
yeikel
left a comment
There was a problem hiding this comment.
I do not have approval rights, but this change looks good. Thanks!
|
|
||
| # Check for updates at https://github.com/nodejs/corepack/releases | ||
| ARG COREPACK_VERSION=0.34.6 | ||
| ARG COREPACK_VERSION=0.34.7 |
There was a problem hiding this comment.
Can we bump it to the version that was just released today?
| ARG COREPACK_VERSION=0.34.7 | |
| ARG COREPACK_VERSION=0.35.0 |
Just to take advantage while we wait for a reviewer :)
There was a problem hiding this comment.
I'll do it when back at my laptop, is the npm bumped too?
There was a problem hiding this comment.
Only concern is that this might be breaking the pnpm and some older smoke tests (and subsequently causing a break in functionality?).
| # Check for updates at https://github.com/nodejs/corepack/releases | ||
| ARG COREPACK_VERSION=0.34.6 | ||
| ARG COREPACK_VERSION=0.35.0 | ||
|
|
| # Check for updates at https://github.com/npm/cli/releases | ||
| # This version should be aligned with NODEJS_VERSION version declared above. See https://nodejs.org/en/download/releases as well | ||
| # With every major release update, also update npm_and_yarn/lib/dependabot/npm_and_yarn/npm_package_manager.rb (Section : Update instructions) | ||
| ARG NPM_VERSION=11.8.0 | ||
| ARG NPM_VERSION=11.12.1 |
|
I understand that it might be busy at Microsoft & GitHub since there have been a few big security breaches, but little things like this should help out, since being able to turn on strict engine requirements for every developer to use a version of npm that supports Let me know/rebase/make a different PR for all I care, I just want to see this upgraded sooner to enable a good DX without having to compromise on security. |
|
@kbukum1 Could you please review this? |
Thanks for the hard work. Hopefully someone with write permissions will get to it soon 🙏 |
This patches over the error mismatch in #14961 + temp work-around until #14139 is done
What are you trying to accomplish?
I want to be able to use npm 11.10+ with strict engine version(s) so I can use the
min-release-agefeature while having dependbot upgrade stuff. Given the repeated npm package hijacks, being able to enforce the engine as a hard blocker is a security essential to reduce the risk of pulling in malware on development/agent controlled machines.See #14961, this is a temp fix by aligning the two versions. Really the
npm --versionneeds some work to be whatever the Dockerfile is actually set to be.Anything you want to highlight for special attention from reviewers?
I would like to highlight that this bump should be automatically by some tooling / someone should put a manual reminder a week after any node LTS release to do this.
How will you know you've accomplished your goal?
Once this is in, I press try again, and it works.
Checklist