Upgrade pip to 26.0.1 to resolve relative path issue in pip-compile#15008
Closed
v-HaripriyaC wants to merge 1 commit into
Closed
Upgrade pip to 26.0.1 to resolve relative path issue in pip-compile#15008v-HaripriyaC wants to merge 1 commit into
v-HaripriyaC wants to merge 1 commit into
Conversation
v-HaripriyaC
force-pushed
the
chp/Upgrade-pipto25
branch
12 times, most recently
from
ea398c0 to
5ce42c5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Python helper toolchain around pip/pip-compile behavior, adds handling for newer pip-compile resolution errors, and introduces regression coverage for relative requirement paths.
Changes:
- Pins the Python helper pip version to
26.0.1. - Adds handling for pip-tools module errors and “Could not find a version that matches” failures.
- Adds a regression fixture/spec for pip-compile relative path annotations and allow-lists two pip advisories in dependency review.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/dependency-review.yml |
Adds GHSA allow-list entries for pip advisories. |
python/helpers/requirements.txt |
Updates the pinned pip helper version. |
python/lib/dependabot/python/file_updater/pip_compile_file_updater.rb |
Converts pip-compile version-matching failures into DependencyFileNotResolvable. |
python/lib/dependabot/python/update_checker/pip_compile_version_resolver.rb |
Adds piptools missing-module and version-matching error handling. |
python/spec/dependabot/python/file_updater/pip_compile_file_updater_spec.rb |
Adds a regression spec for relative paths in pip-compile output. |
python/spec/dependabot/python/update_checker/pip_compile_version_resolver_spec.rb |
Adds coverage for version-matching errors in the pip-compile error handler. |
python/spec/fixtures/requirements/pip_compile_relative_paths.txt |
Adds a generated requirements fixture with relative # via -r annotations. |
v-HaripriyaC
changed the title
Closed
v-HaripriyaC
force-pushed
the
chp/Upgrade-pipto25
branch
2 times, most recently
from
fc6e2a7 to
2b2b19f
Compare
v-HaripriyaC
force-pushed
the
chp/Upgrade-pipto25
branch
from
2b2b19f to
ff426a8
Compare
Upgrade pip from 24.2 to 26.0.1 in the Python helpers requirements. This resolves the relative path handling issue in pip-compile that caused 'Could not find a version that matches' errors. pip 26.0.1 is the highest version that still supports Python 3.9, which is needed since dependabot-core supports Python 3.9.24. pip 26.1+ drops Python 3.9 support. Also adds error handling for version matching errors and ModuleNotFoundError for piptools in the pip-compile resolvers. Allow-lists GHSA-58qw-9mgm-455v and GHSA-jp4c-xjxw-mgf9 in the dependency-review workflow since these are only fixed in pip 26.1+ which drops Python 3.9.
v-HaripriyaC
force-pushed
the
chp/Upgrade-pipto25
branch
from
ff426a8 to
bf41c6c
Compare
Comment on lines
+245
to
+247
| check_original_requirements_resolvable | ||
| cleaned_message = clean_error_message(message) | ||
| raise DependencyFileNotResolvable, cleaned_message.empty? ? message : cleaned_message |
Comment on lines
+246
to
+247
| cleaned_message = clean_error_message(message) | ||
| raise DependencyFileNotResolvable, cleaned_message.empty? ? message : cleaned_message |
Comment on lines
+73
to
+75
| it "does not raise an error" do | ||
| expect { error_handler.handle_pipcompile_error(exception_message) } | ||
| .not_to raise_error |
Comment on lines
+30
to
+32
| allow-ghsas: >- | ||
| GHSA-58qw-9mgm-455v, | ||
| GHSA-jp4c-xjxw-mgf9 |
Contributor
Author
|
fixing as part of #15058 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on the issue: #12663, since pip 25.2 version is incompatible, with pip-compile,
What are you trying to accomplish?
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist