fix(github_actions): align SHA updates with cooldown-filtered latest version#15078
Merged
thavaahariharangit merged 4 commits intoMay 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the github-actions update flow so SHA-based ref rewrites use the same cooldown-filtered decision as latest_version, preventing Dependabot from reporting (and attempting) updates to SHAs that are filtered out by cooldown rules.
Changes:
- Update
latest_commit_shato preferlatest_versionwhen it’s a SHA String (so cooldown-filtered SHAs are respected). - Add/adjust spec coverage to assert SHA alignment with
latest_versionrather than falling back to branch head behavior.
Show a summary per file
| File | Description |
|---|---|
| github_actions/lib/dependabot/github_actions/update_checker.rb | Aligns SHA rewrite selection with cooldown-filtered latest_version to avoid reporting updates to cooled-down SHAs. |
| github_actions/spec/dependabot/github_actions/update_checker_spec.rb | Updates the #latest_commit_sha spec to validate the new alignment behavior using a cooldown-filtered SHA. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
1 task
kbukum1
approved these changes
May 20, 2026
markhallen
pushed a commit
that referenced
this pull request
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
I worked on a fix for issue #14998 and reproduced the problem in this workflow run:
github-action-cooldown-14998 workflow run
After cooldown filtering, Dependabot correctly identifies the current SHA as the latest allowed version:
However, the pull request summary still reports an update to the cooled-down SHA instead of the filtered result:
In short, cooldown filtering is applied when determining
latest_versionbut the update summary is still built from the unfiltered SHA.Anything you want to highlight for special attention from reviewers?
Cooldown filtering already applied to
latest_version, but SHA-based ref rewriting could still use the unfiltered branch head. This change keeps both paths aligned so the reported update matches the actual cooled-down result.How will you know you've accomplished your goal?
After this change, the run produced no update when the candidate SHA is filtered out by cooldown. I verified that behavior in a dependabot cli run against above workflow that we reproduced this issue, where Dependabot correctly reports that there is nothing to update:
Checklist