Skip to content

change test for file path to account for empty string #15109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettfo merged 1 commit into from
May 22, 2026
+6 −2
Merged

change test for file path to account for empty string #15109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/SdkProjectDiscovery.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,12 +722,16 @@ PackageManagementKind.CentralPackageManagement or
_ => null,
};

if (packageManagementFile is not null)
// If a repo has an incomplete setup of package management, it's possible we detect it but then get an
// empty string for the special file path. The fix is to explicitly check for that and not just a null
// value. A check below will then autocorrect to default package management since that's what's really
// being used.
if (!string.IsNullOrWhiteSpace(packageManagementFile))
{
packageManagementFile = Path.GetRelativePath(projectFullDirectory, packageManagementFile).NormalizePathToUnix();
}

if (packageManagementKind != PackageManagementKind.Default && packageManagementFile is null)
if (packageManagementKind != PackageManagementKind.Default && string.IsNullOrWhiteSpace(packageManagementFile))
{
logger.Warn($"Project [{projectRelativePath}] detected package management kind of {packageManagementKind} but no package management file found; forcing management kind to {PackageManagementKind.Default}.");
packageManagementKind = PackageManagementKind.Default;
Expand Down
Loading