Stabilize poetry smoke fixture by ignoring transitive certifi and idna releases#462
Merged
Merged
Conversation
Merged
5 tasks
Contributor
Author
|
@kbukum1 tagging you because you seemed to review a similar PR recently - apologies if that's not the right ping! |
kbukum1
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a certifi ignore condition to
smoke-python-poetry.yamlso the Poetry smoke test remains deterministic whencertifiandidnapublish a new release.Why this is needed
This came up for my dependabot-core PR - the e2e smoke tests were failing because of
certifiandidna. The smoke-python-poetry fixture currently pins lockfile content that includescertifiandidnaartifacts.When a new
certifioridnarelease appears on PyPI, Poetry can update that transitive dependency during unrelated updates (for examplerequests), which causes fixture expectation drift and smoke failures.This failure mode is:
In other words, the smoke test becomes flaky due to upstream package churn, not due to a regression in Dependabot logic.
What changed
In
smoke-python-poetry.yaml, underinput.job.ignore-conditions, add:dependency-name: certifisource: tests/smoke-python-poetry.yamlversion-requirement: '>2026.2.25'idnaEffect
This keeps the fixture stable by preventing transitive
certifiandidnaupdates beyond the fixture’s pinned baseline while preserving coverage for the intended top-level updates in this smoke scenario.Scope
This change is intentionally narrow:
smoke-python-poetry.Validation
smoke-python-poetry.yaml.