Skip to content

refactor: improve logs and add exception stack trace for YarnAuditAnalyzer #7694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremylong merged 2 commits into from
May 31, 2025
Merged

refactor: improve logs and add exception stack trace for YarnAuditAnalyzer #7694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f103ced
refactor: #7692 Change identical log messages to help identify the be…
nhumblot May 30, 2025
4857e9b
refactor: #7692 add stack trace at debug level
nhumblot May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/java/org/owasp/dependencycheck/analyzer/NodePackageAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ private boolean isNodeAuditEnabled(Engine engine) {
try {
((AbstractNpmAnalyzer) a).prepareFileTypeAnalyzer(engine);
} catch (InitializationException ex) {
LOGGER.debug("Error initializing the {}", a.getName());
String message = "Error initializing the " + a.getName();
LOGGER.debug(message, ex);
}
}
return a.isEnabled();
Expand Down
6 changes: 4 additions & 2 deletions core/src/main/java/org/owasp/dependencycheck/analyzer/YarnAuditAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,14 @@ protected void prepareFileTypeAnalyzer(Engine engine) throws InitializationExcep
case yarnExecutableNotFoundExitValue:
default:
this.setEnabled(false);
LOGGER.warn("The {} has been disabled. Yarn executable was not found.", getName());
LOGGER.warn("The {} has been disabled after receiving exit value {}. Yarn executable was not " +
"found or received a non-zero exit value.", getName(), exitValue);
}
}
} catch (Exception ex) {
this.setEnabled(false);
LOGGER.warn("The {} has been disabled. Yarn executable was not found.", getName());
LOGGER.warn("The {} has been disabled after receiving an exception. This can occur when Yarn executable " +
"is not found.", getName());
throw new InitializationException("Unable to read yarn audit output.", ex);
}
}
Expand Down