test: fix expectations for RetireJS against AngularJS integration test#8511
Merged
jeremylong merged 1 commit intoMay 19, 2026
Merged
Conversation
Bounds matching was fixed upstream, which removed a false positive in our expectations Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
chadlwilson
changed the title
jeremylong
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Integration tests are currently failing on
masteras some bounds matching/generation was fixed upstream in RetireJS via RetireJS/retire.js#571, which removed a false positive in our expectations. (now that CVE only correctly matches for Angular1.3.1+, our test mocks Angular1.2.27)Related issues
N/A
Have test cases been added to cover the new functionality?
yes