PHPStan: cleanup setup (#4222)

Author: staabm

phpstan.neon

@@ -9,9 +9,16 @@ parameters:
         - recipe
         - contrib
 
+    bootstrapFiles:
+        - tests/constants.php
+
+    dynamicConstantNames:
+        DEPLOYER_VERSION: string
+        DEPLOYER_BIN: string
+        MASTER_ENDPOINT: string
+        MASTER_TOKEN: string
+
     ignoreErrors:
-        - "#^Constant DEPLOYER_VERSION not found\\.$#"
-        - "#^Constant DEPLOYER_BIN not found\\.$#"
         - "#^Constant MASTER_ENDPOINT not found\\.$#"
         - "#^Constant MASTER_TOKEN not found\\.$#"
         - "#CpanelPhp#"

src/Configuration.php

@@ -17,6 +17,9 @@
 use function Deployer\Support\is_closure;
 use function Deployer\Support\normalize_line_endings;
 
+/**
+ * @implements \ArrayAccess<string, mixed>
+ */
 class Configuration implements \ArrayAccess
 {
     private ?Configuration $parent;

tests/bootstrap.php

@@ -21,10 +21,7 @@
 set_include_path(__DIR__ . '/..' . PATH_SEPARATOR . get_include_path());
 
 putenv('DEPLOYER_LOCAL_WORKER=true');
-define('DEPLOYER_BIN', __DIR__ . '/../bin/dep');
-define('__FIXTURES__', __DIR__ . '/fixtures');
-define('__REPOSITORY__', __DIR__ . '/fixtures/repository');
-define('__TEMP_DIR__', sys_get_temp_dir() . '/deployer');
+require_once __DIR__ . '/constants.php';
 
 require_once __DIR__ . '/spec/SpecTest.php';
 

tests/constants.php

@@ -0,0 +1,7 @@
+<?php
+
+define('DEPLOYER_BIN', __DIR__ . '/../bin/dep');
+define('DEPLOYER_VERSION', 'dev-master');
+define('__FIXTURES__', __DIR__ . '/fixtures');
+define('__REPOSITORY__', __DIR__ . '/fixtures/repository');
+define('__TEMP_DIR__', sys_get_temp_dir() . '/deployer');