Replace noCleanup with killOnTimeout for clearer timeout behavior in SSH operations

Author: antonmedv

src/Ssh/RunParams.php

@@ -11,7 +11,7 @@ public function __construct(
         public ?string $dotenv = null,
         public bool    $nothrow = false,
         public ?int    $timeout = null,
-        public bool    $noCleanup = false,
+        public bool    $killOnTimeout = true,
         public ?int    $idleTimeout = null,
         public bool    $forceOutput = false,
         #[\SensitiveParameter]
@@ -22,12 +22,12 @@ public function with(
         #[\SensitiveParameter]
         ?array $secrets = null,
         ?int $timeout = null,
-        ?bool $noCleanup = null,
+        ?bool $killOnTimeout = null,
     ): self {
         $params = clone $this;
         $params->secrets = array_merge($params->secrets ?? [], $secrets ?? []);
         $params->timeout = $timeout ?? $params->timeout;
-        $params->noCleanup = $noCleanup ?? $params->noCleanup;
+        $params->killOnTimeout = $killOnTimeout ?? $params->killOnTimeout;
         return $params;
     }
 }

src/Ssh/SshClient.php

@@ -76,18 +76,19 @@ public function run(Host $host, string $command, RunParams $params): string
             $process->run($callback);
         } catch (ProcessTimedOutException $exception) {
             // Let's try to kill all processes started by this command.
-            // Cleanup runs pass noCleanup so a timeout here can't recurse,
-            // and cleanup failures must not mask the timeout, so swallow them.
-            if (!$params->noCleanup) {
+            // Cleanup runs pass killOnTimeout: false so a timeout here can't
+            // recurse, and cleanup failures must not mask the timeout, so
+            // swallow them.
+            if ($params->killOnTimeout) {
                 try {
                     $pid = trim($this->run(
                         $host,
                         "ps x | grep $shellId | grep -v grep | awk '{print \$1}'",
-                        $params->with(timeout: 10, noCleanup: true),
+                        $params->with(timeout: 10, killOnTimeout: false),
                     ));
                     if ($pid !== '') {
                         // Minus before pid means all processes in this group.
-                        $this->run($host, "kill -9 -$pid", $params->with(timeout: 20, noCleanup: true));
+                        $this->run($host, "kill -9 -$pid", $params->with(timeout: 20, killOnTimeout: false));
                     }
                 } catch (\Throwable) {
                     // The shell may have already exited, or `ps`/`kill` may be