chore: bump eslint from 9.39.4 to 10.6.0#5091
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
b286ead to
b80dfd5
Compare
dependabot
Bot
changed the title
b80dfd5 to
1c05ea0
Compare
| * @param {Object} spec Properties to use in place of the element when instantiated on Elements from other frames | ||
| */ | ||
| const DqElement = memoize(function DqElement(elm, options, spec) { | ||
| const DqElement = memoize(function DqElementMemoized(elm, options, spec) { |
There was a problem hiding this comment.
Quick clarity question — the *Memoized suffix here (and on getPseudoElementAreaMemoized in lib/checks/color/color-contrast-evaluate.js:204) names the inner raw implementation, but the memoization actually lives on the outer const DqElement = memoize(...). So a stack trace frame labeled DqElementMemoized would be the un-memoized inner call. Was that intentional, or worth swapping to something like _DqElement / DqElementImpl to keep the name aligned with what the function does?
There was a problem hiding this comment.
This has been our naming convention. The inner function is the same name as the outer function but with memoized attached. See https://github.com/search?q=repo%3Adequelabs%2Faxe-core%20memoize(&type=code. The only reason we bother to name the inner function at all is just to make stack traces easier
|
A newer version of eslint exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.4 to 10.6.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.4...v10.6.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.2.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
changed the title
cc25cb3 to
853a4fb
Compare
|
@dependabot rebase |
|
Looks like this PR is already up-to-date with develop! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
| const globals = require('globals'); | ||
| const mochaNoOnly = require('eslint-plugin-mocha-no-only'); | ||
|
|
||
| // Shared `no-restricted-syntax` selectors. ESLint flat config replaces (does |
There was a problem hiding this comment.
Eslint reported that utils/get-node-attributes wasn't reporting any errors for no-restricted-syntax when it should have been. Turns out that when we moved to flat config it also meant that later rules would override prior ones. In this case the rule for utils that prevented vNode use overrode the base config to prevent node.attributes, which is why it was no longer being reported. The fix is to have the base no-restricted-syntax rule as an object and spread them any time we create a new rule that overrides no-restricted-syntax.
3 participants
Bumps eslint from 9.39.4 to 10.6.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
5d12a0410.6.0f7ca54bBuild: changelog update for 10.6.06a42034ci: run ecosystem tests on main branch (#20891)b1f9106feat: detect Symbol() and BigInt() in no-constant-binary-expression (#20981)3dbacdbci: bump actions/checkout from 6 to 7 (#21014)c3abfcachore: correct JSDoc param types in html formatter (#21018)a83683ddocs: Update READMEa832320ci: split ecosystem tests into separate jobs (#21001)6b05784fix: prefer-exponentiation-operator invalid autofix at statement start (#20997)bb9eb2afix: account for shadowedBooleaninno-extra-boolean-cast(#21013)