fix(gather-internals): handle non-HTMLElement nodes#5161
Merged
Conversation
WilcoFiers
approved these changes
Jun 12, 2026
| // convert idref to node ancestry | ||
| // aria props can use unattached nodes but those won't be used by the browser to calculate the prop value | ||
| if (value instanceof globalThis.HTMLElement) { | ||
| if (value instanceof globalThis.Node) { |
Contributor
There was a problem hiding this comment.
This may need to be Element? I tested it out, you can't assign text nodes to ariaLabelledbyElement. So that's good. In practice this shouldn't matter, so I think it's fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Nodeinstead ofHTMLElementwhen checking the element internals prop value so we include all node types, such as SVGs. This is the follow up to a similar problem in theget-aria-valuepr.I also added an eslint rule to prevent us from using
HTMLElementsin the future so we don't make the same mistake again.