Skip to content

Commit 7c91594

Browse files
committed
test: remove test_msc_and_mscmsm_suffix_acronyms
A parse-behavior test on two specific acronyms doesn't generalize to catch other missing-comma bugs in SUFFIX_ACRONYMS; it only documents this one instance. Not the right way to guard against this class of bug.
1 parent 859d759 commit 7c91594

1 file changed

Lines changed: 0 additions & 15 deletions

File tree

tests/test_suffixes.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,6 @@ def test_suffix_with_periods(self) -> None:
1919
self.m(hn.last, "Dentist", hn)
2020
self.m(hn.suffix, "D.D.S.", hn)
2121

22-
def test_msc_and_mscmsm_suffix_acronyms(self) -> None:
23-
# Regression guard: SUFFIX_ACRONYMS had a missing comma between 'msc'
24-
# and 'mscmsm', so Python's implicit string-literal concatenation
25-
# silently merged them into a bogus 'mscmscmsm' entry, dropping both
26-
# real entries from the set.
27-
hn = HumanName("Joe Dentist Msc")
28-
self.m(hn.first, "Joe", hn)
29-
self.m(hn.last, "Dentist", hn)
30-
self.m(hn.suffix, "Msc", hn)
31-
32-
hn2 = HumanName("Joe Dentist MSCMSM")
33-
self.m(hn2.first, "Joe", hn2)
34-
self.m(hn2.last, "Dentist", hn2)
35-
self.m(hn2.suffix, "MSCMSM", hn2)
36-
3722
def test_two_suffixes(self) -> None:
3823
hn = HumanName("Kenneth Clarke QC MP")
3924
self.m(hn.first, "Kenneth", hn)

0 commit comments

Comments
 (0)