fix: add re.I to east_slavic_patronymic_cyrillic regex

Unlike its Latin sibling and the new turkic_patronymic_marker_cyrillic
pattern, this pattern had no re.I flag. The irregular-form alternatives
(ильич, кузьмич, лукич, фомич, фокич) are short enough that the
capitalized first letter falls within the matched suffix itself, so
capitalized real-world patronymics like "Ильич" failed to match and
HumanName("Иванов Иван Ильич", constants=Constants(patronymic_name_order=True))
did not rotate, while the equivalent Latin-script name did.

Also strengthens test_no_regex_collision_latin/_cyrillic with positive
sanity assertions confirming each word list actually matches its own
family's regex, so the non-collision assertions are non-vacuous.

Author: derek73

nameparser/config/regexes.py

@@ -28,6 +28,7 @@
     )),
     ("east_slavic_patronymic_cyrillic", re.compile(
         r'(ович|овна|евич|евна|ична|ильич|кузьмич|лукич|фомич|фокич)$',
+        re.I,
     )),
     ("turkic_patronymic_marker", re.compile(
         r"^(oglu|oğlu|ogly|ogli|o['’ʻ]g['’ʻ]li"

tests/test_patronymic_order.py

@@ -31,6 +31,19 @@ def test_cyrillic_patronymic_matches() -> None:
     assert C.regexes.east_slavic_patronymic_cyrillic.search("ильич")
 
 
+def test_cyrillic_patronymic_matches_capitalized_irregular_forms() -> None:
+    # The irregular forms (Ильич, Кузьмич, ...) are short enough that the
+    # capitalized first letter falls within the matched suffix itself, unlike
+    # the common suffixes (-ович, -евна, ...) where only the surname root is
+    # capitalized. Case-insensitivity is required for these to match.
+    C = Constants()
+    assert C.regexes.east_slavic_patronymic_cyrillic.search("Ильич")
+    assert C.regexes.east_slavic_patronymic_cyrillic.search("Кузьмич")
+    assert C.regexes.east_slavic_patronymic_cyrillic.search("Лукич")
+    assert C.regexes.east_slavic_patronymic_cyrillic.search("Фомич")
+    assert C.regexes.east_slavic_patronymic_cyrillic.search("Фокич")
+
+
 def test_cyrillic_patronymic_rejects_non_patronymic() -> None:
     C = Constants()
     assert not C.regexes.east_slavic_patronymic_cyrillic.search("Иванов")
@@ -77,6 +90,14 @@ def test_cyrillic(self) -> None:
         assert n.middle == "Иванович"
         assert n.last == "Иванов"
 
+    def test_cyrillic_capitalized_irregular_form(self) -> None:
+        # "Ильич" is short enough that the capitalized first letter falls
+        # within the irregular suffix itself; requires case-insensitive match.
+        n = self.hn("Иванов Иван Ильич")
+        assert n.first == "Иван"
+        assert n.middle == "Ильич"
+        assert n.last == "Иванов"
+
     def test_title_preserved(self) -> None:
         n = self.hn("Dr. Ivanov Ivan Ivanovich")
         assert n.title == "Dr."

tests/test_turkic_patronymic_order.py

@@ -274,8 +274,12 @@ def test_no_regex_collision_latin(self) -> None:
             "qizi", "qızı", "kizi", "kyzy", "gyzy", "uly", "uulu",
         ]
         for word in east_slavic_examples:
+            # Sanity check: each word actually matches its own family's
+            # regex, so the non-collision assertion below is non-vacuous.
+            assert C.regexes.east_slavic_patronymic.search(word), word
             assert not C.regexes.turkic_patronymic_marker.match(word), word
         for word in turkic_examples:
+            assert C.regexes.turkic_patronymic_marker.match(word), word
             assert not C.regexes.east_slavic_patronymic.search(word), word
 
     def test_no_regex_collision_cyrillic(self) -> None:
@@ -289,6 +293,10 @@ def test_no_regex_collision_cyrillic(self) -> None:
             "кызы", "гызы", "қызы", "қизи", "улы", "ұлы", "уулу",
         ]
         for word in east_slavic_examples:
+            # Sanity check: each word actually matches its own family's
+            # regex, so the non-collision assertion below is non-vacuous.
+            assert C.regexes.east_slavic_patronymic_cyrillic.search(word), word
             assert not C.regexes.turkic_patronymic_marker_cyrillic.match(word), word
         for word in turkic_examples:
+            assert C.regexes.turkic_patronymic_marker_cyrillic.match(word), word
             assert not C.regexes.east_slavic_patronymic_cyrillic.search(word), word