Address queue review follow-ups

Author: dereuromark

src/Controller/Admin/QueueController.php

@@ -118,7 +118,28 @@ public function index() {
 
 		$configurations = (array)Configure::read('Queue');
 
-		$this->set(['new' => $new, 'current' => $current, 'data' => $data, 'pendingDetails' => $pendingDetails, 'scheduledDetails' => $scheduledDetails, 'pendingDetailsTruncated' => $pendingDetailsTruncated, 'scheduledDetailsTruncated' => $scheduledDetailsTruncated, 'detailsLimit' => $detailsLimit, 'totalPending' => $totalPending, 'status' => $status, 'tasks' => $tasks, 'addableTasks' => $addableTasks, 'taskDescriptions' => $taskDescriptions, 'servers' => $servers, 'workers' => $workers, 'pendingJobs' => $pendingJobs, 'scheduledJobs' => $scheduledJobs, 'runningJobs' => $runningJobs, 'failedJobs' => $failedJobs, 'configurations' => $configurations]);
+		$this->set(compact(
+			'new',
+			'current',
+			'data',
+			'pendingDetails',
+			'scheduledDetails',
+			'pendingDetailsTruncated',
+			'scheduledDetailsTruncated',
+			'detailsLimit',
+			'totalPending',
+			'status',
+			'tasks',
+			'addableTasks',
+			'taskDescriptions',
+			'servers',
+			'workers',
+			'pendingJobs',
+			'scheduledJobs',
+			'runningJobs',
+			'failedJobs',
+			'configurations',
+		));
 	}
 
 	/**

src/Model/Table/QueuedJobsTable.php

@@ -267,7 +267,7 @@ public function createJob(string $jobTask, array|object|null $data = null, array
 	 * @return string
 	 */
 	protected function jobTask(string $jobType): string {
-		if (!$this->taskFinder instanceof TaskFinder) {
+		if (!($this->taskFinder instanceof TaskFinder)) {
 			$this->taskFinder = new TaskFinder();
 		}
 

src/Queue/TaskFinder.php

@@ -145,7 +145,7 @@ public function resolve(string $jobTask): string {
 
 		if (!str_contains($jobTask, '\\')) {
 			// Let's try matching without plugin prefix
-			foreach (array_keys($all) as $name) {
+			foreach ($all as $name => $_) {
 				if (!str_contains($name, '.')) {
 					continue;
 				}

tests/TestCase/Model/Table/QueuedJobsTableTest.php

@@ -321,11 +321,11 @@ public function testSequence() {
 	}
 
 	/**
-     * Test creating Jobs to run close to a specified time, and strtotime parsing.
-     * Using toUnixString() function to convert Time object to timestamp, instead of strtotime
-     *
-     * @return void
-     */
+	 * Test creating Jobs to run close to a specified time, and strtotime parsing.
+	 * Using toUnixString() function to convert Time object to timestamp, instead of strtotime
+	 *
+	 * @return void
+	 */
 	public function testNotBefore() {
 		$this->assertTrue((bool)$this->QueuedJobs->createJob('Foo', null, ['notBefore' => '+ 1 Min']));
 		$this->assertTrue((bool)$this->QueuedJobs->createJob('Foo', null, ['notBefore' => '+ 1 Day']));