Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.

    -- org.elasticsearch.plugins.changes.ChangesPlugin
    -- org.elasticsearch.plugins.changes.module.ChangesModule
    -- org.elasticsearch.plugins.changes.rest.action.ChangesAction

Collection.isEmpty() should be used to test for emptiness
    -- org.elasticsearch.plugins.changes.rest.action.ChangesAction

Left curly braces should be located at the end of lines of code
    -- org.elasticsearch.plugins.changes.util.ConcurrentCircularBuffer

Tabulation characters should not be used
    -- org.elasticsearch.plugins.changes.util.ConcurrentCircularBuffer
    -- org.elasticsearch.plugins.changes.beans.Change
    -- org.elasticsearch.plugins.changes.beans.IndexChangeWatcher
    -- org.elasticsearch.plugins.changes.beans.IndexChanges

Override equals, hashcode in IndexChanges

Author: flavioperezcarreto

src/main/java/org/elasticsearch/plugins/changes/ChangesPlugin.java

@@ -26,27 +26,27 @@
 import org.elasticsearch.plugins.changes.module.ChangesModule;
 
 public class ChangesPlugin extends AbstractPlugin {
-	private static final ESLogger log=Loggers.getLogger(ChangesPlugin.class);
-	private final Collection<Class<? extends Module>> modules;
-	
-	public ChangesPlugin() {
-		log.info("Starting ChangesPlugin");
-		
-		Collection<Class<? extends Module>> tempList=new ArrayList<Class<? extends Module>>(1);
-		tempList.add(ChangesModule.class);
-		modules=Collections.unmodifiableCollection(tempList);
-	}
-	
-	@Override
-	public Collection<Class<? extends Module>> modules() {
-		return modules;
-	}
-
-	public String description() {
-		return "Changes Plugin";
-	}
-
-	public String name() {
-		return "changes";
-	}
+    private static final ESLogger LOG = Loggers.getLogger(ChangesPlugin.class);
+    private final Collection<Class<? extends Module>> modules;
+    
+    public ChangesPlugin() {
+        LOG.info("Starting ChangesPlugin");
+        
+        Collection<Class<? extends Module>> tempList=new ArrayList<Class<? extends Module>>(1);
+        tempList.add(ChangesModule.class);
+        modules=Collections.unmodifiableCollection(tempList);
+    }
+    
+    @Override
+    public Collection<Class<? extends Module>> modules() {
+        return modules;
+    }
+
+    public String description() {
+        return "Changes Plugin";
+    }
+
+    public String name() {
+        return "changes";
+    }
 }

src/main/java/org/elasticsearch/plugins/changes/beans/Change.java

@@ -16,54 +16,70 @@
 package org.elasticsearch.plugins.changes.beans;
 
 public class Change implements Comparable<Change> {
-	long timestamp;
-	Type type;
-	String id;
-	long version;
-	
-	public long getTimestamp() {
-		return timestamp;
-	}
-
-	public void setTimestamp(long timestamp) {
-		this.timestamp = timestamp;
-	}
-
-	public Type getType() {
-		return type;
-	}
-
-	public void setType(Type type) {
-		this.type = type;
-	}
-
-	public String getId() {
-		return id;
-	}
-
-	public void setId(String id) {
-		this.id = id;
-	}
-
-	public long getVersion() {
-		return version;
-	}
-
-	public void setVersion(long version) {
-		this.version = version;
-	}
-
-	public enum Type {
-		INDEX,CREATE,DELETE;
-	}
-
-	public int compareTo(Change o) {
-		if (this.timestamp<o.timestamp) {
-			return -1;
-		} else if (this.timestamp>o.timestamp) {
-			return 1;
-		} else {
-			return 0;
-		}
-	}
+    long timestamp;
+    Type type;
+    String id;
+    long version;
+    
+    public long getTimestamp() {
+        return timestamp;
+    }
+
+    public void setTimestamp(long timestamp) {
+        this.timestamp = timestamp;
+    }
+
+    public Type getType() {
+        return type;
+    }
+
+    public void setType(Type type) {
+        this.type = type;
+    }
+
+    public String getId() {
+        return id;
+    }
+
+    public void setId(String id) {
+        this.id = id;
+    }
+
+    public long getVersion() {
+        return version;
+    }
+
+    public void setVersion(long version) {
+        this.version = version;
+    }
+
+    public enum Type {
+        INDEX,CREATE,DELETE;
+    }
+
+    @Override
+    public int compareTo(Change o) {
+        if (this.timestamp<o.timestamp) {
+            return -1;
+        } else if (this.timestamp>o.timestamp) {
+            return 1;
+        } else {
+            return 0;
+        }
+    }
+
+    @Override
+    public boolean equals(Object o) {
+        if (!(o instanceof Change)) {
+            return false;
+        }
+
+        Change other = (Change)o;
+        return this.timestamp == other.timestamp;
+    }
+
+    @Override
+    public int hashCode() {
+        return this.hashCode();
+    }
 }

src/main/java/org/elasticsearch/plugins/changes/beans/IndexChangeWatcher.java

@@ -19,42 +19,42 @@
 import java.util.concurrent.TimeUnit;
 
 public class IndexChangeWatcher {
-	String indexName;
-	Change change;
-	Semaphore barrier;
-	long timeout;
-	
-	public IndexChangeWatcher() {
-		this.barrier=new Semaphore(0);
-		this.timeout=15*60*1000;
-	}
-	
-	public IndexChangeWatcher(long timeout) {
-		this.barrier=new Semaphore(0);
-		this.timeout=timeout;
-	}
-	
-	public void permit() {
-		barrier.release();
-	}
-	
-	public boolean aquire() throws InterruptedException {
-		return barrier.tryAcquire(timeout, TimeUnit.MILLISECONDS);
-	}
-
-	public String getIndexName() {
-		return indexName;
-	}
-
-	public void setIndexName(String indexName) {
-		this.indexName = indexName;
-	}
-
-	public Change getChange() {
-		return change;
-	}
-
-	public void setChange(Change change) {
-		this.change = change;
-	}
+    String indexName;
+    Change change;
+    Semaphore barrier;
+    long timeout;
+    
+    public IndexChangeWatcher() {
+        this.barrier=new Semaphore(0);
+        this.timeout=15*60*1000;
+    }
+    
+    public IndexChangeWatcher(long timeout) {
+        this.barrier=new Semaphore(0);
+        this.timeout=timeout;
+    }
+    
+    public void permit() {
+        barrier.release();
+    }
+    
+    public boolean aquire() throws InterruptedException {
+        return barrier.tryAcquire(timeout, TimeUnit.MILLISECONDS);
+    }
+
+    public String getIndexName() {
+        return indexName;
+    }
+
+    public void setIndexName(String indexName) {
+        this.indexName = indexName;
+    }
+
+    public Change getChange() {
+        return change;
+    }
+
+    public void setChange(Change change) {
+        this.change = change;
+    }
 }