Skip to content

Commit fe31794

Browse files
committed
Merge remote-tracking branch 'upstream/trunk' into trunk
# Conflicts: # .github/workflows/check-built-files.yml # .github/workflows/reusable-check-built-files.yml
2 parents b551ece + 6f9d8e6 commit fe31794

40 files changed

Lines changed: 439 additions & 181 deletions

.github/workflows/check-built-files.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ concurrency:
3232
# The concurrency group contains the workflow name and the branch name for pull requests
3333
# or the commit hash for any other events.
3434
group: ${{ github.workflow }}-${{ github.event_name == 'pull_request_target' && github.head_ref || github.sha }}
35-
35+
cancel-in-progress: true
3636

3737
# Disable permissions for all available scopes by default.
3838
# Any needed permissions should be configured at the job level.

.github/workflows/end-to-end-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ on:
3333
- 'tests/e2e/**'
3434
# Confirm any changes to relevant workflow files.
3535
- '.github/workflows/end-to-end-tests.yml'
36-
- '.github/workflows/reusable-end-to-end-tests-*.yml'
36+
- '.github/workflows/reusable-end-to-end-tests*.yml'
3737
workflow_dispatch:
3838

3939
# Cancels all previous workflow runs for pull requests that have not completed.

.github/workflows/reusable-check-built-files.yml

Lines changed: 26 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,33 @@ jobs:
2929
# - Builds Emoji files.
3030
# - Builds bundled Root Certificate files.
3131
# - Builds WordPress.
32+
<<<<<<< HEAD
3233
# - Configures the Git author.
3334
# - Checks for changes to versioned files.
35+
=======
36+
# - Checks for changes to versioned files.
37+
# - Displays the result of git diff for debugging purposes.
38+
# - Configures the Git author.
39+
>>>>>>> upstream/trunk
3440
# - Stages changes.
3541
# - Commits changes.
3642
# - Pushes changes.
3743
update-built-files:
3844
name: Check and update built files
3945
runs-on: ubuntu-24.04
46+
<<<<<<< HEAD
4047
permissions:
4148
contents: write
4249
# This prevents a second run after changes are committed back because Dependabot always rebases updates onto trunk.
4350
if: ${{ github.actor != 'dependabot[bot]' || github.event.commits < 2 }}
51+
=======
52+
# This prevents an unnecessary second run after changes are committed back because Dependabot always rebases
53+
# updates and force pushes.
54+
if: ${{ github.actor != 'dependabot[bot]' || github.event.commits < 2 }}
55+
timeout-minutes: 10
56+
permissions:
57+
contents: write
58+
>>>>>>> upstream/trunk
4459
steps:
4560
- name: Generate Installation Token
4661
id: generate_token
@@ -56,7 +71,11 @@ jobs:
5671
private_key = open("private-key.pem", "r").read()
5772
payload = {
5873
"iat": int(time.time()),
74+
<<<<<<< HEAD
5975
"exp": int(time.time()) + 60, # 1-minute expiration
76+
=======
77+
"exp": int(time.time()) + 600, # 10-minute expiration
78+
>>>>>>> upstream/trunk
6079
"iss": $GH_APP_ID
6180
}
6281
print(jwt.encode(payload, private_key, algorithm="RS256"))
@@ -127,11 +146,6 @@ jobs:
127146
- name: Build WordPress
128147
run: npm run build:dev
129148

130-
- name: Configure git user name and email
131-
run: |
132-
git config user.name "dependabot[bot]"
133-
git config user.email 49699333+dependabot[bot]@users.noreply.github.com
134-
135149
- name: Check for changes to versioned files
136150
id: built-file-check
137151
run: |
@@ -142,8 +156,15 @@ jobs:
142156
fi
143157
144158
- name: Display changes to versioned files
159+
if: ${{ steps.built-file-check.outputs.uncommitted_changes == 'true' }}
145160
run: git diff
146161

162+
- name: Configure git user name and email
163+
if: ${{ steps.built-file-check.outputs.uncommitted_changes == 'true' }}
164+
run: |
165+
git config user.name "dependabot[bot]"
166+
git config user.email 49699333+dependabot[bot]@users.noreply.github.com
167+
147168
- name: Stage changes
148169
if: ${{ steps.built-file-check.outputs.uncommitted_changes == 'true' }}
149170
run: git add .

.github/workflows/reusable-end-to-end-tests.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@ on:
2828
description: 'A specific version of Gutenberg to install.'
2929
required: false
3030
type: 'string'
31+
install-playwright:
32+
description: 'Whether to install Playwright browsers.'
33+
required: false
34+
type: 'boolean'
35+
default: true
3136

3237
env:
3338
LOCAL_DIR: build
@@ -94,6 +99,7 @@ jobs:
9499
run: npm ci
95100

96101
- name: Install Playwright browsers
102+
if: ${{ inputs.install-playwright }}
97103
run: npx playwright install --with-deps
98104

99105
- name: Build WordPress

src/js/_enqueues/admin/common.js

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -419,12 +419,18 @@ window.columns = {
419419
*/
420420
saveManageColumnsState : function() {
421421
var hidden = this.hidden();
422-
$.post(ajaxurl, {
423-
action: 'hidden-columns',
424-
hidden: hidden,
425-
screenoptionnonce: $('#screenoptionnonce').val(),
426-
page: pagenow
427-
});
422+
$.post(
423+
ajaxurl,
424+
{
425+
action: 'hidden-columns',
426+
hidden: hidden,
427+
screenoptionnonce: $('#screenoptionnonce').val(),
428+
page: pagenow
429+
},
430+
function() {
431+
wp.a11y.speak( __( 'Screen Options updated.' ) );
432+
}
433+
);
428434
},
429435

430436
/**

src/js/_enqueues/admin/postbox.js

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -461,13 +461,19 @@
461461
closed = $( '.postbox' ).filter( '.closed' ).map( function() { return this.id; } ).get().join( ',' );
462462
hidden = $( '.postbox' ).filter( ':hidden' ).map( function() { return this.id; } ).get().join( ',' );
463463

464-
$.post(ajaxurl, {
465-
action: 'closed-postboxes',
466-
closed: closed,
467-
hidden: hidden,
468-
closedpostboxesnonce: jQuery('#closedpostboxesnonce').val(),
469-
page: page
470-
});
464+
$.post(
465+
ajaxurl,
466+
{
467+
action: 'closed-postboxes',
468+
closed: closed,
469+
hidden: hidden,
470+
closedpostboxesnonce: jQuery('#closedpostboxesnonce').val(),
471+
page: page
472+
},
473+
function() {
474+
wp.a11y.speak( __( 'Screen Options updated.' ) );
475+
}
476+
);
471477
},
472478

473479
/**

src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ tinymce.PluginManager.add( 'wordpress', function( editor ) {
116116

117117
event.content = event.content.replace( /<!--more(.*?)-->/g, function( match, moretext ) {
118118
return '<img src="' + tinymce.Env.transparentSrc + '" data-wp-more="more" data-wp-more-text="' + moretext + '" ' +
119-
'class="wp-more-tag mce-wp-more" alt="" title="' + title + '" data-mce-resize="false" data-mce-placeholder="1" />';
119+
'class="wp-more-tag mce-wp-more" alt="' + title + '" data-mce-resize="false" data-mce-placeholder="1" />';
120120
});
121121
}
122122

@@ -125,7 +125,7 @@ tinymce.PluginManager.add( 'wordpress', function( editor ) {
125125

126126
event.content = event.content.replace( /<!--nextpage-->/g,
127127
'<img src="' + tinymce.Env.transparentSrc + '" data-wp-more="nextpage" class="wp-more-tag mce-wp-nextpage" ' +
128-
'alt="" title="' + title + '" data-mce-resize="false" data-mce-placeholder="1" />' );
128+
'alt="' + title + '" data-mce-resize="false" data-mce-placeholder="1" />' );
129129
}
130130

131131
if ( event.load && event.format !== 'raw' ) {
@@ -144,10 +144,9 @@ tinymce.PluginManager.add( 'wordpress', function( editor ) {
144144
'data-wp-preserve="' + encodeURIComponent( match ) + '" ' +
145145
'data-mce-resize="false" ' +
146146
'data-mce-placeholder="1" '+
147-
'class="mce-object" ' +
147+
'class="mce-object mce-object-' + tag + '" ' +
148148
'width="20" height="20" '+
149149
'alt="&lt;' + tag + '&gt;" ' +
150-
'title="&lt;' + tag + '&gt;" ' +
151150
'/>';
152151
} );
153152
}
@@ -214,7 +213,7 @@ tinymce.PluginManager.add( 'wordpress', function( editor ) {
214213
classname += ' mce-wp-' + tag;
215214
title = tag === 'more' ? 'Read more...' : 'Next page';
216215
title = __( title );
217-
html = '<img src="' + tinymce.Env.transparentSrc + '" alt="" title="' + title + '" class="' + classname + '" ' +
216+
html = '<img src="' + tinymce.Env.transparentSrc + '" alt="' + title + '" class="' + classname + '" ' +
218217
'data-wp-more="' + tag + '" data-mce-resize="false" data-mce-placeholder="1" />';
219218

220219
// Most common case.
Lines changed: 1 addition & 0 deletions
Loading
Lines changed: 1 addition & 0 deletions
Loading

src/js/_enqueues/vendor/tinymce/skins/wordpress/wp-content.css

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,14 @@ img[data-mce-selected]::selection {
160160
background: transparent url( images/pagebreak.png ) repeat-y scroll center center;
161161
}
162162

163+
.mce-object-style {
164+
background-image: url( images/style.svg );
165+
}
166+
167+
.mce-object-script {
168+
background-image: url( images/script.svg );
169+
}
170+
163171
/* Styles for formatting the boundaries of anchors and code elements */
164172
.mce-content-body a[data-mce-selected] {
165173
padding: 0 2px;

0 commit comments

Comments
 (0)