Closed
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
Author
This patch adds a clarifying note about what constitutes a valid UTF-8 byte stream. This was brought up in review as a potentially ambiguous term, so a link to the spec has been provided to fix the behavior to the standard. Developed in WordPress#9716 Discussed in https://core.trac.wordpress.org/ticket/38044 Follow-up to [60630]. Props dmsnell, agulbra. See #38044. git-svn-id: https://develop.svn.wordpress.org/trunk@60702 602fd350-edb4-49c9-b593-d223f7449a82
Several PHP functions that have not been doing anything since PHP 8.0/8.1, specifically: * `finfo_close()` since the `ext/fileinfo` migration in PHP 8.1 * `xml_parser_free()` since the `ext/xml` migration in PHP 8.0 * `curl_close()` since the `ext/curl` migration in PHP 8.0 * `curl_share_close()` since the `ext/curl` migration in PHP 8.0 * `imagedestroy()` since the `ext/gd` migration in PHP 8.0 will be deprecated in PHP 8.5 and will thus be throwing warnings. This commit adds conditional checks to only call these functions on the relevant PHP versions. Reference: [https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_no-op_functions_from_the_resource_to_object_conversion PHP RFC: Deprecations for PHP 8.5: Deprecate no-op functions from the resource to object conversion]. Props TobiasBg, SergeyBiryukov. See #63061. git-svn-id: https://develop.svn.wordpress.org/trunk@60703 602fd350-edb4-49c9-b593-d223f7449a82
* Allow scripts and script modules to be registered with a `fetchpriority` of `auto` (default), `high`, `low`: * When registering a script, add a `fetchpriority` arg to go alongside the `strategy` arg which was added for loading scripts with the `defer` and `async` loading strategies. See #12009. * For script modules, introduce an `$args` array parameter with a `fetchpriority` key to the `wp_register_script_module()`, and `wp_enqueue_script_module()` functions (and their respective underlying `WP_Script_Modules::register()` and `WP_Script_Modules::enqueue()` methods). This `$args` parameter corresponds with the same parameter used when registering non-module scripts. * Also for script modules, introduce `WP_Script_Modules::set_fetchpriority()` to override the `fetchpriority` for what was previously registered. * Emit a `_doing_it_wrong()` warning when an invalid `fetchpriority` value is used, and when `fetchpriority` is added to a script alias. * Include `fetchpriority` as an attribute on printed `SCRIPT` tags as well as on preload `LINK` tags for static script module dependencies. * Use a `fetchpriority` of `low` by default for: * Script modules used with the Interactivity API. For overriding this default in blocks, see [WordPress/gutenberg#71366 Gutenberg#71366]. * The `comment-reply` script. * Improve type checks and type hints. Developed in [WordPress#8815 GitHub PR], with [WordPress/gutenberg#70173 companion for Gutenberg]. Props westonruter, jonsurrell, swissspidy, luisherranz, kraftbj, audrasjb, dennysdionigi. Fixes #61734. git-svn-id: https://develop.svn.wordpress.org/trunk@60704 602fd350-edb4-49c9-b593-d223f7449a82
Page title actions were modified to match the global button styles in #41986, but these styles were not applied to mobile viewports at the time. Fix padding, height, line-height, and alignment to match these links to global styles. Props joedolson, rollybueno, sumitbagthariya16, circlecube, shailu25. Fixes #63831. git-svn-id: https://develop.svn.wordpress.org/trunk@60705 602fd350-edb4-49c9-b593-d223f7449a82
Prevent WP_Tag_Processor::set_modifiable_text() from allowing SCRIPT contents with "<script" like it does with "</script". Either of these sequences may affect the script element's close. Developed in WordPress#9560. Props jonsurrell, westonruter, dmsnell. See #63738. git-svn-id: https://develop.svn.wordpress.org/trunk@60706 602fd350-edb4-49c9-b593-d223f7449a82
`assertEqualHTML` catches `Exception`s and attempts to re-parse the HTML with the `Dom\HtmlDocument` class. Ensure that the fallback render is reachable by throwing `Exception` instead of `Error` in the tree builder function. Developed in WordPress#9273. Follow-up to [60295]. Props jonsurrell, bernhard-reiter, dmsnell. Fixes #63527. git-svn-id: https://develop.svn.wordpress.org/trunk@60707 602fd350-edb4-49c9-b593-d223f7449a82
…butes. Corrects an issue with block attribute encoding where JSON strings ending in the `\` character would be misencoded and cause block attributes to be lost. Client-side block serialization was updated with matching logic in WordPress/gutenberg@10453ab. Developed in WordPress#9558. Props jonsurrell, westonruter, mamaduka, dmsnell, shailu25. Fixes #63917. git-svn-id: https://develop.svn.wordpress.org/trunk@60708 602fd350-edb4-49c9-b593-d223f7449a82
…r()`. Follow-up to [20936], [21354], [37283]. Props rollybueno, SergeyBiryukov. See #63166. git-svn-id: https://develop.svn.wordpress.org/trunk@60709 602fd350-edb4-49c9-b593-d223f7449a82
Remove some CSS that doesn't appear to have ever been used. See [42967]. Props joedolson, peterwilsoncc, mukesh27. Fixes #63907. git-svn-id: https://develop.svn.wordpress.org/trunk@60710 602fd350-edb4-49c9-b593-d223f7449a82
…are updated. This allows plugins to run custom queries only when a term count is actually updated and not on every update of terms or posts. Follow-up to [60365], [60510]. Props leonidasmilossis, peterwilsoncc, mukesh27, rollybueno, SergeyBiryukov. Fixes #63904. git-svn-id: https://develop.svn.wordpress.org/trunk@60711 602fd350-edb4-49c9-b593-d223f7449a82
…w user creation. After [60634], `wp_set_password` is now fired during new user creation and existing user updates when a password is changed. `wp_set_password` expects the third argument to be a `WP_User` object of the user's data prior to the update. This change simply passes the newly created `WP_User` object. Follow-up to [60634]. Props dd32. See #22114. git-svn-id: https://develop.svn.wordpress.org/trunk@60712 602fd350-edb4-49c9-b593-d223f7449a82
…s in `wp-admin/post.php`. The status code is now explicitly set in each `wp_die()` call so that the default 500 status code is not sent unless it is the most appropriate. Props callumbw95, kkmuffme, mindctrl, westonruter. Fixes #63836. git-svn-id: https://develop.svn.wordpress.org/trunk@60713 602fd350-edb4-49c9-b593-d223f7449a82
…no_hash()`. Follow-up to [20936], [21354], [37283], [60709]. Props rollybueno, SergeyBiryukov. See #63166. git-svn-id: https://develop.svn.wordpress.org/trunk@60714 602fd350-edb4-49c9-b593-d223f7449a82
When setting the home page settings or dynamically adding new pages in the menu manager, the error messages didn't meet accessibility standards. Add a screen reader announcement, a visible notification, and standardize the error styles. Props dilipbheda, dlh, celloexpressions, joedolson, jeremiahbratton, shailu25. Fixes #50696. git-svn-id: https://develop.svn.wordpress.org/trunk@60715 602fd350-edb4-49c9-b593-d223f7449a82
…pgrade_682()`. Follow-up to [60666]. See #53323. git-svn-id: https://develop.svn.wordpress.org/trunk@60716 602fd350-edb4-49c9-b593-d223f7449a82
This aims to improve performance of some queries on installations with a large number of posts. Follow-up to [3678], [3690], [9290], [13576]. Props josephscott, LucasMS, Otto42, flixos90, matt, johnjamesjacoby, siliconforks, mukesh27, jonsurrell, SirLouen, SergeyBiryukov. Fixes #50161. git-svn-id: https://develop.svn.wordpress.org/trunk@60717 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [60717]. See #50161. git-svn-id: https://develop.svn.wordpress.org/trunk@60718 602fd350-edb4-49c9-b593-d223f7449a82
Improve the source locations referenced by developer tooling in supporting browsers. Inline source locations are named like inline:handle-js-after and appear in the developer tools "sources" panel. This is the second attempt to add sourceURL comments. The first attempt in [60685] was reverted due to an issue with script concatenation that has been addressed. Developed in WordPress#9672. Follow-up to [60685], [60690]. Props jonsurrell, westonruter, wildworks, peterwilsoncc, johnbillion, tobiasbg. Fixes #63887. git-svn-id: https://develop.svn.wordpress.org/trunk@60719 602fd350-edb4-49c9-b593-d223f7449a82
Refactoring covered:
- Use the newly introduced `block_bindings_supported_attributes_{$block_name}` filter to register a `test/block`'s attribute as supported by Block Bindings, rather than using an actual block (Paragraph) for most tests.
- Merge three test cases that check if `get_value_callback` works correctly (accepts arguments; correctly includes symbols and numbers; return value is sanitized when rendered) into one, by using a `dataProvider`.
- Merge two test cases that check if block context is correctly evaluated, and that access is only given to context included in a source's `uses_context` property.
Follow-up to [60684].
Props bernhard-reiter, gziolo.
See #63840.
git-svn-id: https://develop.svn.wordpress.org/trunk@60720 602fd350-edb4-49c9-b593-d223f7449a82
This commit: * Moves the call to `upgrade_690()` to the correct place so it actually gets called. * Wraps Hello Dolly upgrade code in a version check per standard practice. * Removes the `$wpdb->query()` call to avoid attempting to create the new index twice, once in the upgrade and once in `dbDelta()`. Follow-up to [60666], [60716], [60717]. Props peterwilsoncc, mukesh27. See #50161, #53323. git-svn-id: https://develop.svn.wordpress.org/trunk@60721 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/62811
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.