You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 22, 2024. It is now read-only.
I see the majority of the changes are adding Union[<type>, None] type hints for parameters. The recommended way to type hint this is to use typing.Optional, which is basically an alias for Union[<type>, None]. Also, a lot of the changes are duplicated in #69, perhaps it would be best to review that PR and see what could be merged there?
I see the majority of the changes are adding Union[, None] type hints for parameters. The recommended way to type hint this is to use typing.Optional, which is basically an alias for Union[, None]. Also, a lot of the changes are duplicated in #69, perhaps it would be best to review that PR and see what could be merged there?
I am not sure about the ideal way of using typing hints in Python. I think Union and Optional are equivalent. In the future, we will use type | None instead of both. Also, in my opinion, Union is more like the new typing hint.
I am not sure about the ideal way of using typing hints in Python. I think Union and Optional are equivalent. In the future, we will use type | None instead of both. Also, in my opinion, Union is more like the new typing hint.
Optional is the way to go. They are virtually equivalent (see https://peps.python.org/pep-0645/), but optional is a more readable way to express the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.