overflow handling and new tests

Author: dev-11

Clocks.Tests/ClockIn24HTests.cs

@@ -149,5 +149,39 @@ public void AddSecondAddsSecond(int seconds, int expectedHour, int expectedMinut
             clock.Minute.Should().Be(expectedMinute);
             clock.Second.Should().Be(expectedSecond);
         }
+
+        [Fact]
+        public void AddMinuteRollsHour()
+        {
+            var clock = new ClockIn24H(1,30, 0);
+            clock.Hour.Should().Be(1);
+            clock.Minute.Should().Be(30);
+            clock.Second.Should().Be(0);
+            clock.Invariant.Should().BeTrue();
+
+            clock.AddMinutes(30);
+            
+            clock.Invariant.Should().BeTrue();
+            clock.Hour.Should().Be(2);
+            clock.Minute.Should().Be(0);
+            clock.Second.Should().Be(0);
+        }
+
+        [Fact]
+        public void AddSecondsRollsMinuteAndHour()
+        {
+            var clock = new ClockIn24H(0,59, 59);
+            clock.Hour.Should().Be(0);
+            clock.Minute.Should().Be(59);
+            clock.Second.Should().Be(59);
+            clock.Invariant.Should().BeTrue();
+
+            clock.AddSeconds(61);
+
+            clock.Invariant.Should().BeTrue();
+            clock.Hour.Should().Be(1);
+            clock.Minute.Should().Be(1);
+            clock.Second.Should().Be(0);
+        }
     }
 }

Clocks.Tests/StopwatchTests.cs

@@ -154,6 +154,24 @@ public void AddSecondAddsSecond(int seconds, int expectedHour, int expectedMinut
             stopwatch.Second.Should().Be(expectedSecond);
         }
 
+        [Fact]
+        public void AddSecondAddsSecond2()
+        {
+            var stopwatch = new Stopwatch(23, 59, 59);
+
+            stopwatch.Hour.Should().Be(23);
+            stopwatch.Minute.Should().Be(59);
+            stopwatch.Second.Should().Be(59);
+            stopwatch.Invariant.Should().BeTrue();
+            
+            stopwatch.AddSeconds(1);
+
+            stopwatch.Invariant.Should().BeTrue();
+            stopwatch.Hour.Should().Be(24);
+            stopwatch.Minute.Should().Be(0);
+            stopwatch.Second.Should().Be(0);
+        }
+
         [Fact]
         public void AddHoursBreaksInvariantWithMaxValueOverflow()
         {

Clocks/BaseClock.cs

@@ -28,15 +28,20 @@ public void AddHours(int hour)
 
         public void AddMinutes(int minute)
         {
-            Hour   += minute / 60;
-            Minute += minute % 60;
+            var newMinute = Minute + minute;
+
+            Hour   += newMinute / 60;
+            Minute  = newMinute % 60;
         }
 
         public void AddSeconds(int second)
         {
-            Hour   += second / 3600;
-            Minute += second % 3600 / 60;
-            Second += second % 3600 % 60;
+            var newSecond = Second + second;
+            var newMinute = Minute + newSecond % 3600 / 60;
+
+            Hour   += newMinute / 60 + newSecond / 3600 % 60;
+            Minute  = newMinute % 60;
+            Second  = newSecond % 3600 % 60;
         }
     }
 }