CI: fix review assignment GH action (prebid#14346)

* pr assignment split

* add checkout

* add output

* pass PR number

* fix prNo

* add missing fs import

* Add more missing imports

* add ref: master

* fix quoting

* fix quoting, again

* add condition on triggering workflow

Author: dgirardi

.github/actions/unzip-artifact/action.yml

@@ -0,0 +1,49 @@
+name: Unzip artifact
+description: Download and unzip artifact from a triggering workflow
+inputs:
+  name:
+    description: Artifact name
+outputs:
+  exists:
+    description: true if the artifact was found
+    value: ${{ steps.download.outputs.result }}
+
+runs:
+  using: 'composite'
+  steps:
+    - name: 'Download artifact'
+      id: download
+      uses: actions/github-script@v8
+      with:
+        result-encoding: string
+        script: |
+          let allArtifacts = await github.rest.actions.listWorkflowRunArtifacts({
+             owner: context.repo.owner,
+             repo: context.repo.repo,
+             run_id: context.payload.workflow_run.id,
+          });
+          let matchArtifact = allArtifacts.data.artifacts.filter((artifact) => {
+            return artifact.name == "${{ inputs.name }}"
+          })[0];
+          if (matchArtifact == null) {
+            return "false"
+          }
+          let download = await github.rest.actions.downloadArtifact({
+             owner: context.repo.owner,
+             repo: context.repo.repo,
+             artifact_id: matchArtifact.id,
+             archive_format: 'zip',
+          });
+          const fs = require('fs');
+          const path = require('path');
+          const temp = '${{ runner.temp }}/artifacts';
+          if (!fs.existsSync(temp)){
+            fs.mkdirSync(temp);
+          }
+          fs.writeFileSync(path.join(temp, 'artifact.zip'), Buffer.from(download.data));
+          return "true";
+
+    - name: 'Unzip artifact'
+      shell: bash
+      if: ${{ steps.download.outputs.result == 'true' }}
+      run: unzip "${{ runner.temp }}/artifacts/artifact.zip" -d "${{ runner.temp }}/artifacts"

.github/workflows/PR-assignment-deps.yml

@@ -0,0 +1,34 @@
+name: Compile dependencies.json for PR assignment checks
+on:
+  pull_request:
+    types: [opened, synchronize, reopened]
+permissions:
+  contents: read
+jobs:
+  generate_deps:
+    name: Generate dependencies.json
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+        with:
+          ref: refs/pull/${{ github.event.pull_request.number }}/head
+      - name: Install dependencies
+        uses: ./.github/actions/npm-ci
+      - name: Build
+        run: |
+          npx gulp build
+      - name: Upload dependencies.json
+        uses: actions/upload-artifact@v4
+        with:
+          name: dependencies.json
+          path: ./build/dist/dependencies.json
+      - name: Generate PR info
+        run: |
+          echo '{ "prNo": ${{ github.event.pull_request.number }} }' >> ${{ runner.temp}}/prInfo.json
+      - name: Upload PR info
+        uses: actions/upload-artifact@v4
+        with:
+          name: prInfo
+          path: ${{ runner.temp}}/prInfo.json

.github/workflows/PR-assignment.yml

@@ -1,31 +1,35 @@
 name: Assign PR reviewers
 on:
-  pull_request_target:
-    types: [opened, synchronize, reopened]
-
+  workflow_run:
+    workflows:
+      - Compile dependencies.json for PR assignment checks
+    types:
+      - completed
 jobs:
   assign_reviewers:
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}
     name: Assign reviewers
     runs-on: ubuntu-latest
 
     steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+        with:
+          ref: master
       - name: Generate app token
         id: token
         uses: actions/create-github-app-token@v2
         with:
           app-id: ${{ vars.PR_BOT_ID }}
           private-key: ${{ secrets.PR_BOT_PEM }}
-
-      - name: Checkout
-        uses: actions/checkout@v6
+      - name: Download dependencies.json
+        uses: ./.github/actions/unzip-artifact
         with:
-          ref: refs/pull/${{ github.event.pull_request.number }}/head
-
-      - name: Install dependencies
-        uses: ./.github/actions/npm-ci
-      - name: Build
-        run: |
-          npx gulp build
+          name: dependencies.json
+      - name: Download PR info
+        uses: ./.github/actions/unzip-artifact
+        with:
+          name: prInfo
       - name: Install s3 client
         run: |
           npm install @aws-sdk/client-s3
@@ -35,14 +39,17 @@ jobs:
         env:
           AWS_ACCESS_KEY_ID: ${{ vars.PR_BOT_AWS_AK }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.PR_BOT_AWS_SAK }}
+          DEPENDENCIES_JSON: ${{ runner.temp }}/artifacts/dependencies.json
         with:
           github-token: ${{ steps.token.outputs.token }}
           script: |
+            const fs = require('fs');
             const getProps = require('./.github/workflows/scripts/getPRProperties.js')
+            const { prNo }  = JSON.parse(fs.readFileSync('${{runner.temp}}/artifacts/prInfo.json').toString());
             const props = await getProps({
               github, 
               context, 
-              prNo: ${{ github.event.pull_request.number }},
+              prNo,
               reviewerTeam: '${{ vars.REVIEWER_TEAM }}',
               engTeam: '${{ vars.ENG_TEAM }}',
               authReviewTeam: '${{ vars.AUTH_REVIEWER_TEAM }}'

.github/workflows/comment.yml

@@ -16,44 +16,18 @@ jobs:
   comment:
     runs-on: ubuntu-latest
     steps:
-      - name: 'Download artifact'
-        id: download
-        uses: actions/github-script@v8
+      - name: Checkout
+        uses: actions/checkout@v6
         with:
-          result-encoding: string
-          script: |
-            let allArtifacts = await github.rest.actions.listWorkflowRunArtifacts({
-               owner: context.repo.owner,
-               repo: context.repo.repo,
-               run_id: context.payload.workflow_run.id,
-            });
-            let matchArtifact = allArtifacts.data.artifacts.filter((artifact) => {
-              return artifact.name == "comment"
-            })[0];
-            if (matchArtifact == null) {
-              return "false"
-            }
-            let download = await github.rest.actions.downloadArtifact({
-               owner: context.repo.owner,
-               repo: context.repo.repo,
-               artifact_id: matchArtifact.id,
-               archive_format: 'zip',
-            });
-            const fs = require('fs');
-            const path = require('path');
-            const temp = '${{ runner.temp }}/artifacts';
-            if (!fs.existsSync(temp)){
-              fs.mkdirSync(temp);
-            }
-            fs.writeFileSync(path.join(temp, 'comment.zip'), Buffer.from(download.data));
-            return "true";
-
-      - name: 'Unzip artifact'
-        if: ${{ steps.download.outputs.result == 'true' }}
-        run: unzip "${{ runner.temp }}/artifacts/comment.zip" -d "${{ runner.temp }}/artifacts"
+          ref: master
+      - name: Retrieve comment data
+        id: get-comment
+        uses: ./.github/actions/unzip-artifact
+        with:
+          name: comment
 
       - name: 'Comment on PR'
-        if: ${{ steps.download.outputs.result == 'true' }}
+        if: ${{ steps.get-comment.outputs.exists == 'true' }}
         uses: actions/github-script@v8
         with:
           script: |

.github/workflows/scripts/getPRProperties.js

@@ -1,5 +1,6 @@
 const ghRequester = require('./ghRequest.js');
 const AWS = require("@aws-sdk/client-s3");
+const fs = require('fs');
 
 const MODULE_PATTERNS = [
   /^modules\/([^\/]+)BidAdapter(\.(\w+)|\/)/,
@@ -25,7 +26,7 @@ function extractVendor(chunkName) {
 }
 
 const getLibraryRefs = (() => {
-  const deps = require('../../../build/dist/dependencies.json');
+  const deps = JSON.parse(fs.readFileSync(process.env.DEPENDENCIES_JSON).toString());
   const refs = {};
   return function (libraryName) {
     if (!refs.hasOwnProperty(libraryName)) {