Optimize export devup

Author: owjs3901

src/commands/devup/__tests__/index.test.ts

@@ -278,6 +278,68 @@ describe('devup commands', () => {
     )
   })
 
+  test('exportDevup treeshake true stops early once a typography key is found', async () => {
+    getColorCollectionSpy = spyOn(
+      getColorCollectionModule,
+      'getDevupColorCollection',
+    ).mockResolvedValue(null)
+    styleNameToTypographySpy = spyOn(
+      styleNameToTypographyModule,
+      'styleNameToTypography',
+    ).mockImplementation((name: string) =>
+      name.includes('2')
+        ? ({ level: 1, name: 'heading' } as const)
+        : ({ level: 0, name: 'heading' } as const),
+    )
+    textStyleToTypographySpy = spyOn(
+      textStyleToTypographyModule,
+      'textStyleToTypography',
+    ).mockReturnValue({ fontFamily: 'Inter' } as unknown as DevupTypography)
+
+    const currentTextNode = {
+      type: 'TEXT',
+      textStyleId: 'style1',
+      getStyledTextSegments: () => [{ textStyleId: 'style1' }],
+    } as unknown as TextNode
+    const currentPageFindAllWithCriteria = mock(() => [currentTextNode])
+    const otherPageFindAllWithCriteria = mock(() => [])
+    const rootFindAllWithCriteria = mock(() => [])
+    const currentPage = {
+      id: 'page-current',
+      findAllWithCriteria: currentPageFindAllWithCriteria,
+    } as unknown as PageNode
+    const otherPage = {
+      id: 'page-other',
+      findAllWithCriteria: otherPageFindAllWithCriteria,
+    } as unknown as PageNode
+
+    ;(globalThis as { figma?: unknown }).figma = {
+      util: { rgba: (v: unknown) => v },
+      currentPage,
+      loadAllPagesAsync: async () => {},
+      getLocalTextStylesAsync: async () => [
+        { id: 'style1', name: 'heading/1' } as unknown as TextStyle,
+        { id: 'style2', name: 'heading/2' } as unknown as TextStyle,
+      ],
+      root: {
+        children: [otherPage, currentPage],
+        findAllWithCriteria: rootFindAllWithCriteria,
+      },
+      mixed: Symbol('mixed'),
+      variables: { getVariableByIdAsync: async () => null },
+    } as unknown as typeof figma
+
+    await exportDevup('json', true)
+
+    expect(currentPageFindAllWithCriteria).toHaveBeenCalledTimes(1)
+    expect(otherPageFindAllWithCriteria).not.toHaveBeenCalled()
+    expect(rootFindAllWithCriteria).not.toHaveBeenCalled()
+    expect(downloadFileMock).toHaveBeenCalledWith(
+      'devup.json',
+      expect.stringContaining('"typography"'),
+    )
+  })
+
   test('exportDevup fills missing typography levels from styles map', async () => {
     getColorCollectionSpy = spyOn(
       getColorCollectionModule,

src/commands/devup/export-devup.ts

@@ -82,8 +82,13 @@ export async function exportDevup(
   // Build both ID-keyed and name-keyed maps from a single fetch
   const stylesById = new Map<string, TextStyle>()
   const styles: Record<string, TextStyle> = {}
+  const styleMetaById = new Map<string, { level: number; name: string }>()
+  const allTypographyKeys = new Set<string>()
   for (const style of textStyles) {
+    const meta = styleNameToTypography(style.name)
     stylesById.set(style.id, style)
+    styleMetaById.set(style.id, meta)
+    allTypographyKeys.add(meta.name)
     styles[style.name] = style
   }
 
@@ -94,47 +99,76 @@ export async function exportDevup(
     const prevSkip = figma.skipInvisibleInstanceChildren
     figma.skipInvisibleInstanceChildren = true
 
-    const tFind = perfStart()
-    const texts = figma.root.findAllWithCriteria({ types: ['TEXT'] })
-    perfEnd('exportDevup.typography.find', tFind)
-
-    const tScan = perfStart()
-    const foundStyleIds = new Set<string>()
-    for (const text of texts) {
-      // Early exit: all local styles discovered
-      if (foundStyleIds.size >= stylesById.size) break
+    const usedTypographyKeys = new Set<string>()
+    const processText = (text: TextNode) => {
+      if (usedTypographyKeys.size >= allTypographyKeys.size) return
       if (
         !(typeof text.textStyleId === 'string' && text.textStyleId) &&
         text.textStyleId !== figma.mixed
       )
-        continue
+        return
 
       if (typeof text.textStyleId === 'string') {
-        // Single-style node — skip getStyledTextSegments entirely
         const style = stylesById.get(text.textStyleId)
-        if (!style || foundStyleIds.has(text.textStyleId)) continue
-        foundStyleIds.add(text.textStyleId)
-        const { level, name } = styleNameToTypography(style.name)
+        const meta = styleMetaById.get(text.textStyleId)
+        if (!style || !meta || usedTypographyKeys.has(meta.name)) return
+        usedTypographyKeys.add(meta.name)
+        const { level, name } = meta
         if (!typography[name]?.[level]) {
           typography[name] ??= [null, null, null, null, null, null]
           typography[name][level] = textStyleToTypography(style)
         }
-        continue
+        return
       }
 
-      // Mixed-style node — only request textStyleId (1 field vs 8)
       for (const seg of text.getStyledTextSegments(['textStyleId'])) {
-        if (!seg?.textStyleId || foundStyleIds.has(seg.textStyleId)) continue
+        if (usedTypographyKeys.size >= allTypographyKeys.size) return
+        if (!seg?.textStyleId) continue
         const style = stylesById.get(seg.textStyleId)
-        if (!style) continue
-        foundStyleIds.add(seg.textStyleId)
-        const { level, name } = styleNameToTypography(style.name)
+        const meta = styleMetaById.get(seg.textStyleId)
+        if (!style || !meta || usedTypographyKeys.has(meta.name)) continue
+        usedTypographyKeys.add(meta.name)
+        const { level, name } = meta
         if (typography[name]?.[level]) continue
         typography[name] ??= [null, null, null, null, null, null]
         typography[name][level] = textStyleToTypography(style)
       }
     }
-    perfEnd('exportDevup.typography.scan', tScan)
+
+    const rootPages = Array.isArray(figma.root.children)
+      ? figma.root.children
+      : []
+    if (rootPages.length > 1) {
+      const currentPageId = figma.currentPage.id
+      const orderedPages = [
+        figma.currentPage,
+        ...rootPages.filter((page) => page.id !== currentPageId),
+      ]
+      for (const page of orderedPages) {
+        if (usedTypographyKeys.size >= allTypographyKeys.size) break
+        const tFind = perfStart()
+        const texts = page.findAllWithCriteria({ types: ['TEXT'] })
+        perfEnd('exportDevup.typography.find', tFind)
+
+        const tScan = perfStart()
+        for (const text of texts) {
+          processText(text)
+          if (usedTypographyKeys.size >= allTypographyKeys.size) break
+        }
+        perfEnd('exportDevup.typography.scan', tScan)
+      }
+    } else {
+      const tFind = perfStart()
+      const texts = figma.root.findAllWithCriteria({ types: ['TEXT'] })
+      perfEnd('exportDevup.typography.find', tFind)
+
+      const tScan = perfStart()
+      for (const text of texts) {
+        processText(text)
+        if (usedTypographyKeys.size >= allTypographyKeys.size) break
+      }
+      perfEnd('exportDevup.typography.scan', tScan)
+    }
 
     figma.skipInvisibleInstanceChildren = prevSkip
   } else {