Skip to content

Commit 3ef2b6b

Browse files
authored
Merge pull request #38 from dev-five-git/inline-primary
Fix inline primary key issue
2 parents 585928c + 7be64cb commit 3ef2b6b

5 files changed

Lines changed: 3 additions & 24 deletions

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"changes":{"crates/vespertide-exporter/Cargo.toml":"Patch","crates/vespertide-config/Cargo.toml":"Patch","crates/vespertide-macro/Cargo.toml":"Patch","crates/vespertide-core/Cargo.toml":"Patch","crates/vespertide-planner/Cargo.toml":"Patch","crates/vespertide-query/Cargo.toml":"Patch","crates/vespertide-loader/Cargo.toml":"Patch","crates/vespertide-naming/Cargo.toml":"Patch","crates/vespertide-cli/Cargo.toml":"Patch","crates/vespertide/Cargo.toml":"Patch"},"note":"Fix inline primary key issue","date":"2025-12-24T05:55:32.660669100Z"}

crates/vespertide-core/src/schema/primary_key.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
use schemars::JsonSchema;
22
use serde::{Deserialize, Serialize};
33

4-
use crate::schema::names::ColumnName;
5-
64
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize, JsonSchema)]
75
#[serde(rename_all = "snake_case")]
86
pub struct PrimaryKeyDef {
97
#[serde(default)]
108
pub auto_increment: bool,
11-
pub columns: Vec<ColumnName>,
129
}
1310

1411
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize, JsonSchema)]

crates/vespertide-core/src/schema/table.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1474,7 +1474,6 @@ mod tests {
14741474
let mut id_col = col("id", ColumnType::Simple(SimpleColumnType::Integer));
14751475
id_col.primary_key = Some(PrimaryKeySyntax::Object(PrimaryKeyDef {
14761476
auto_increment: true,
1477-
columns: vec![], // columns is ignored for inline definition
14781477
}));
14791478

14801479
let table = TableDef {

schemas/migration.schema.json

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -528,17 +528,8 @@
528528
"auto_increment": {
529529
"type": "boolean",
530530
"default": false
531-
},
532-
"columns": {
533-
"type": "array",
534-
"items": {
535-
"type": "string"
536-
}
537531
}
538-
},
539-
"required": [
540-
"columns"
541-
]
532+
}
542533
},
543534
"PrimaryKeySyntax": {
544535
"anyOf": [

schemas/model.schema.json

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -299,17 +299,8 @@
299299
"auto_increment": {
300300
"type": "boolean",
301301
"default": false
302-
},
303-
"columns": {
304-
"type": "array",
305-
"items": {
306-
"type": "string"
307-
}
308302
}
309-
},
310-
"required": [
311-
"columns"
312-
]
303+
}
313304
},
314305
"PrimaryKeySyntax": {
315306
"anyOf": [

0 commit comments

Comments
 (0)