Add testcase

Author: owjs3901

crates/vespertide-planner/src/diff.rs

@@ -5163,4 +5163,44 @@ mod tests {
             plan.actions
         );
     }
+
+    #[test]
+    fn diff_mismatched_constraint_types_not_paired() {
+        // Removing a Unique and adding an Index on the same columns should NOT produce
+        // ReplaceConstraint — they are different constraint types (hits _ => false branch).
+        let from = vec![table(
+            "users",
+            vec![col("email", ColumnType::Simple(SimpleColumnType::Text))],
+            vec![TableConstraint::Unique {
+                name: Some("uq_email".into()),
+                columns: vec!["email".into()],
+            }],
+        )];
+        let to = vec![table(
+            "users",
+            vec![col("email", ColumnType::Simple(SimpleColumnType::Text))],
+            vec![idx("ix_email", vec!["email"])],
+        )];
+        let plan = diff_schemas(&from, &to).unwrap();
+        // Should be Remove + Add, not ReplaceConstraint
+        let replace_count = plan
+            .actions
+            .iter()
+            .filter(|a| matches!(a, MigrationAction::ReplaceConstraint { .. }))
+            .count();
+        assert_eq!(
+            replace_count, 0,
+            "Mismatched types should not produce ReplaceConstraint, got: {:?}",
+            plan.actions
+        );
+        assert_eq!(plan.actions.len(), 2);
+        assert!(matches!(
+            &plan.actions[0],
+            MigrationAction::RemoveConstraint { .. }
+        ));
+        assert!(matches!(
+            &plan.actions[1],
+            MigrationAction::AddConstraint { .. }
+        ));
+    }
 }

crates/vespertide-query/src/sql/replace_constraint.rs

@@ -368,11 +368,12 @@ mod tests {
     #[case::sqlite(DatabaseBackend::Sqlite)]
     fn replace_unique_constraint(#[case] backend: DatabaseBackend) {
         // Non-FK constraint: PG/MySQL uses remove+add, SQLite uses temp table
-        let schema = vec![TableDef {
-            name: "users".into(),
-            description: None,
-            columns: vec![
-                ColumnDef {
+        // Multi-table schema so the non-target table hits the else branch (t.clone())
+        let schema = vec![
+            TableDef {
+                name: "other".into(),
+                description: None,
+                columns: vec![ColumnDef {
                     name: "id".into(),
                     r#type: ColumnType::Simple(SimpleColumnType::Integer),
                     nullable: false,
@@ -382,30 +383,48 @@ mod tests {
                     unique: None,
                     index: None,
                     foreign_key: None,
-                },
-                ColumnDef {
-                    name: "email".into(),
-                    r#type: ColumnType::Simple(SimpleColumnType::Text),
-                    nullable: false,
-                    default: None,
-                    comment: None,
-                    primary_key: None,
-                    unique: None,
-                    index: None,
-                    foreign_key: None,
-                },
-            ],
-            constraints: vec![
-                TableConstraint::PrimaryKey {
-                    auto_increment: false,
-                    columns: vec!["id".into()],
-                },
-                TableConstraint::Unique {
-                    name: Some("uq_email".into()),
-                    columns: vec!["email".into()],
-                },
-            ],
-        }];
+                }],
+                constraints: vec![],
+            },
+            TableDef {
+                name: "users".into(),
+                description: None,
+                columns: vec![
+                    ColumnDef {
+                        name: "id".into(),
+                        r#type: ColumnType::Simple(SimpleColumnType::Integer),
+                        nullable: false,
+                        default: None,
+                        comment: None,
+                        primary_key: None,
+                        unique: None,
+                        index: None,
+                        foreign_key: None,
+                    },
+                    ColumnDef {
+                        name: "email".into(),
+                        r#type: ColumnType::Simple(SimpleColumnType::Text),
+                        nullable: false,
+                        default: None,
+                        comment: None,
+                        primary_key: None,
+                        unique: None,
+                        index: None,
+                        foreign_key: None,
+                    },
+                ],
+                constraints: vec![
+                    TableConstraint::PrimaryKey {
+                        auto_increment: false,
+                        columns: vec!["id".into()],
+                    },
+                    TableConstraint::Unique {
+                        name: Some("uq_email".into()),
+                        columns: vec!["email".into()],
+                    },
+                ],
+            },
+        ];
         let from = TableConstraint::Unique {
             name: Some("uq_email".into()),
             columns: vec!["email".into()],