Add default issue

Author: owjs3901

crates/vespertide-query/src/sql/helpers.rs

@@ -264,6 +264,17 @@ pub fn build_sea_column_def_with_table(
                 converted
             };
 
+        // SQLite requires DEFAULT (expr) for expressions containing function calls.
+        // Wrapping in parentheses is always safe for all backends.
+        let final_default = if *backend == DatabaseBackend::Sqlite
+            && final_default.contains('(')
+            && !final_default.starts_with('(')
+        {
+            format!("({})", final_default)
+        } else {
+            final_default
+        };
+
         col.default(Into::<SimpleExpr>::into(sea_query::Expr::cust(
             final_default,
         )));

crates/vespertide-query/src/sql/mod.rs

@@ -1389,6 +1389,53 @@ mod tests {
         });
     }
 
+    #[rstest]
+    #[case::create_table_func_default_postgres(DatabaseBackend::Postgres)]
+    #[case::create_table_func_default_mysql(DatabaseBackend::MySql)]
+    #[case::create_table_func_default_sqlite(DatabaseBackend::Sqlite)]
+    fn test_create_table_with_function_default(#[case] backend: DatabaseBackend) {
+        // SQLite requires DEFAULT (expr) for function-call defaults.
+        // This test ensures parentheses are added for SQLite.
+        let action = MigrationAction::CreateTable {
+            table: "users".into(),
+            columns: vec![
+                ColumnDef {
+                    name: "id".into(),
+                    r#type: ColumnType::Simple(SimpleColumnType::Uuid),
+                    nullable: false,
+                    default: Some("gen_random_uuid()".into()),
+                    comment: None,
+                    primary_key: None,
+                    unique: None,
+                    index: None,
+                    foreign_key: None,
+                },
+                ColumnDef {
+                    name: "created_at".into(),
+                    r#type: ColumnType::Simple(SimpleColumnType::Timestamptz),
+                    nullable: false,
+                    default: Some("now()".into()),
+                    comment: None,
+                    primary_key: None,
+                    unique: None,
+                    index: None,
+                    foreign_key: None,
+                },
+            ],
+            constraints: vec![],
+        };
+        let result = build_action_queries(&backend, &action, &[]).unwrap();
+        let sql = result
+            .iter()
+            .map(|q| q.build(backend))
+            .collect::<Vec<_>>()
+            .join(";\n");
+
+        with_settings!({ snapshot_suffix => format!("create_table_func_default_{:?}", backend) }, {
+            assert_snapshot!(sql);
+        });
+    }
+
     #[rstest]
     #[case::delete_enum_column_postgres(DatabaseBackend::Postgres)]
     #[case::delete_enum_column_mysql(DatabaseBackend::MySql)]

crates/vespertide-query/src/sql/snapshots/vespertide_query__sql__tests__create_table_with_function_default@create_table_func_default_MySql.snap

@@ -0,0 +1,5 @@
+---
+source: crates/vespertide-query/src/sql/mod.rs
+expression: sql
+---
+CREATE TABLE `users` ( `id` binary(16) NOT NULL DEFAULT (UUID()), `created_at` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP )

crates/vespertide-query/src/sql/snapshots/vespertide_query__sql__tests__create_table_with_function_default@create_table_func_default_Postgres.snap

@@ -0,0 +1,5 @@
+---
+source: crates/vespertide-query/src/sql/mod.rs
+expression: sql
+---
+CREATE TABLE "users" ( "id" uuid NOT NULL DEFAULT gen_random_uuid(), "created_at" timestamp with time zone NOT NULL DEFAULT CURRENT_TIMESTAMP )

crates/vespertide-query/src/sql/snapshots/vespertide_query__sql__tests__create_table_with_function_default@create_table_func_default_Sqlite.snap

@@ -0,0 +1,5 @@
+---
+source: crates/vespertide-query/src/sql/mod.rs
+expression: sql
+---
+CREATE TABLE "users" ( "id" uuid_text NOT NULL DEFAULT (lower(hex(randomblob(16)))), "created_at" timestamp_with_timezone_text NOT NULL DEFAULT CURRENT_TIMESTAMP )