Skip to content

Commit ddf34fa

Browse files
committed
Rm continue
1 parent afd4351 commit ddf34fa

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

crates/vespertide-planner/src/validate/check_self_contradiction.rs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -168,13 +168,14 @@ fn flatten_and(parts: &[CheckExpr]) -> Vec<&CheckExpr> {
168168
fn group_predicates_by_column<'a>(flat: &[&'a CheckExpr]) -> Vec<(String, Vec<&'a CheckExpr>)> {
169169
let mut groups: Vec<(String, Vec<&'a CheckExpr>)> = Vec::new();
170170
for pred in flat {
171-
let Some(col) = predicate_column(pred) else {
172-
continue;
173-
};
174-
if let Some((_, existing)) = groups.iter_mut().find(|(c, _)| c == &col) {
175-
existing.push(pred);
176-
} else {
177-
groups.push((col, vec![pred]));
171+
// `if let` (not `let … else { continue; }`) so the skip path folds
172+
// into the loop tail — LLVM coverage mis-attributes a bare `continue`.
173+
if let Some(col) = predicate_column(pred) {
174+
if let Some((_, existing)) = groups.iter_mut().find(|(c, _)| c == &col) {
175+
existing.push(pred);
176+
} else {
177+
groups.push((col, vec![pred]));
178+
}
178179
}
179180
}
180181
groups

0 commit comments

Comments
 (0)