Refactor command registration to optimize version preference retrieval

Author: garrytrinder

src/commands.ts

@@ -5,9 +5,11 @@ import { executeCommand, isConfigFile } from './helpers';
 import { isDevProxyRunning, getDevProxyExe } from './detect';
 
 export const registerCommands = (context: vscode.ExtensionContext, configuration: vscode.WorkspaceConfiguration) => {
+    const versionPreference = configuration.get('version') as VersionPreference;
+    const devProxyExe = getDevProxyExe(configuration.get('version') as VersionPreference);
+
     context.subscriptions.push(
         vscode.commands.registerCommand('dev-proxy-toolkit.install', async (platform: NodeJS.Platform) => {
-            const versionPreference = configuration.get('version') as VersionPreference;
             const message = vscode.window.setStatusBarMessage('Installing Dev Proxy...');
 
             // we are on windows so we can use winget
@@ -86,7 +88,7 @@ export const registerCommands = (context: vscode.ExtensionContext, configuration
         vscode.commands.registerCommand('dev-proxy-toolkit.start', async () => {
             const showTerminal = configuration.get('showTerminal') as boolean;
             const newTerminal = configuration.get('newTerminal') as boolean;
-            const devProxyExe = getDevProxyExe(configuration.get('version') as VersionPreference);
+
 
             let terminal: vscode.Terminal;
 
@@ -106,7 +108,6 @@ export const registerCommands = (context: vscode.ExtensionContext, configuration
     context.subscriptions.push(
         vscode.commands.registerCommand('dev-proxy-toolkit.stop', async () => {
             const apiPort = configuration.get('apiPort') as number;
-            const devProxyExe = getDevProxyExe(configuration.get('version') as VersionPreference);
 
             await fetch(`http://localhost:${apiPort}/proxy/stopproxy`, {
                 method: 'POST',
@@ -148,7 +149,6 @@ export const registerCommands = (context: vscode.ExtensionContext, configuration
     context.subscriptions.push(
         vscode.commands.registerCommand('dev-proxy-toolkit.restart', async () => {
             const apiPort = configuration.get('apiPort') as number;
-            const devProxyExe = getDevProxyExe(configuration.get('version') as VersionPreference);
 
             try {
                 await fetch(`http://localhost:${apiPort}/proxy/stopproxy`, {
@@ -246,17 +246,15 @@ export const registerCommands = (context: vscode.ExtensionContext, configuration
 
     context.subscriptions.push(
         vscode.commands.registerCommand('dev-proxy-toolkit.config-open', async () => {
-            const devProxyExe = getDevProxyExe(configuration.get('version') as VersionPreference);
             await executeCommand(`${devProxyExe} config open`);
         }));
 
     context.subscriptions.push(
         vscode.commands.registerCommand('dev-proxy-toolkit.config-new', async () => {
-            const devProxyExe = getDevProxyExe(configuration.get('version') as VersionPreference);
-
             // ask the user for the filename that they want to use
             const fileName = await vscode.window.showInputBox({
                 prompt: 'Enter the name of the new config file',
+                placeHolder: 'devproxyrc.json',
                 value: 'devproxyrc.json',
                 validateInput: (value: string) => {
                     console.log(value);