Skip to content

Commit 0ec70d6

Browse files
authored
fix: clean publish.yml — remove duplicate ci job (#15)
* ci: add CI workflow with type check, build, verify and dry-run publish Runs on every push and PR across all branches. Checks: - TypeScript (server + admin) - Build - Strapi plugin verify - Version not already published on npm - Dry run publish publish.yml now requires CI to pass before publishing to npm. * fix: replace yarn run -T with npx tsc and fix implicit any type errors - Fix test:ts:front and test:ts:back scripts to use npx tsc (was yarn-only syntax) - Add explicit types for implicit any parameters caught by the type check: MouseEvent on DropZone drag handle click boolean on Modal.Root onOpenChange in EmbedModal and FormPreview string | number on SingleSelect onChange in FieldSettingsPanel and SubmissionsPage * ci: add Dependabot for npm and GitHub Actions weekly updates * fix: remove stale compiled JS files from src and ignore them in .gitignore Rollup was resolving register.js (and other compiled .js files) instead of the .ts sources, causing 'default is not exported' build failures in CI. Deleted all .js artifacts from server/src and admin/src and added them to .gitignore so they are never committed again. * fix: add --noEmit to tsc type-check scripts to prevent JS file generation Without --noEmit, tsc outputs .js files next to the .ts sources. Rollup then resolves the CJS .js files instead of the .ts sources and fails with 'default is not exported' on the CommonJS interop boundary. * ci: prevent double CI run on PR branches Push trigger now only fires on main, development and production. Feature branches are covered by the pull_request trigger alone, so CI no longer runs twice when pushing to an open PR. * chore: bump version to 1.0.0 and complete package.json metadata - Version 1.0.0 (initial public release) - Add description, keywords, repository, bugs and homepage fields - Set strapi.displayName to 'Form Builder CMS' * chore: set version to 1.0.0-alpha.1 and auto-tag alpha/beta/rc on publish * ci: trigger publish on any push to production, not only PR merges * ci: inline CI steps in publish workflow, remove reusable workflow call Calling ci.yml as a reusable workflow while it also triggers independently on push to production caused a workflow file error (0s failure). Inlined all CI steps directly into publish.yml to avoid the conflict. * fix: restore clean publish.yml — remove duplicate ci job from bad merge
1 parent dead148 commit 0ec70d6

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

.github/workflows/publish.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ on:
66
- production
77

88
jobs:
9-
ci:
10-
uses: ./.github/workflows/ci.yml
11-
129
publish:
1310
runs-on: ubuntu-latest
1411

@@ -75,6 +72,3 @@ jobs:
7572
tag_name: v${{ steps.pkg.outputs.version }}
7673
name: v${{ steps.pkg.outputs.version }}
7774
generate_release_notes: true
78-
79-
ci:
80-
uses: ./.github/workflows/ci.yml

0 commit comments

Comments
 (0)